lhc/web/wiklou.git
12 years agoApply patch from Bug 17056 - list items in Special:NewPages should
Mark A. Hershberger [Wed, 16 Nov 2011 21:43:32 +0000 (21:43 +0000)]
Apply patch from Bug 17056 - list items in Special:NewPages should
    each link to the first revision of the page
Patch from Umherirrender

12 years agoApply jdanni's patch from from 2+ years ago for Bug 15218 - LinkSearch results should...
Mark A. Hershberger [Wed, 16 Nov 2011 21:25:31 +0000 (21:25 +0000)]
Apply jdanni's patch from from 2+ years ago for Bug 15218 - LinkSearch results should use as much of the path as is provided, not simply search by domain

Patch only updates the messages.

12 years ago* Put the LinkCache update in WikiPage::updateRevisionOn() so that we are sure that...
Alexandre Emsenhuber [Wed, 16 Nov 2011 21:03:06 +0000 (21:03 +0000)]
* Put the LinkCache update in WikiPage::updateRevisionOn() so that we are sure that it is executed every time that function get called (and the update succeeds of course); and removed the call to Title::resetArticleID() which is already done by insertOn()
* Also update $this->mLatest and $this->mIsRedirect in updateRevisionOn() (will use this in ApiEditPage to have to create another istance just to grab the new revision ID)
* In WikiPage::doEdit(), get the current latest before going through the process since it's now updated in updateRevisionOn() (would break RecentChange::notifyEdit() otherwise) and pass the current redirect state to use the optimisation in updateRedirectOn() if possible

12 years agoPer Aaron, fix for r102973: create directly a WikiFilePage object and call setFile...
Alexandre Emsenhuber [Wed, 16 Nov 2011 20:54:40 +0000 (20:54 +0000)]
Per Aaron, fix for r102973: create directly a WikiFilePage object and call setFile() on it to restore previous behaviour

12 years agoFixed totally broken --file parameter (running the sha1 for one file)
Aaron Schulz [Wed, 16 Nov 2011 20:38:24 +0000 (20:38 +0000)]
Fixed totally broken --file parameter (running the sha1 for one file)

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Wed, 16 Nov 2011 20:05:35 +0000 (20:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoFollowup to r103365, actually include said patch file
OverlordQ [Wed, 16 Nov 2011 19:55:21 +0000 (19:55 +0000)]
Followup to r103365, actually include said patch file

12 years agoFollowup to r100640, use correct name scheme for sequence, correct references to...
OverlordQ [Wed, 16 Nov 2011 19:54:38 +0000 (19:54 +0000)]
Followup to r100640, use correct name scheme for sequence, correct references to sequence and add optional patch file for sites following trunk

12 years ago(bug 31535; bug 332) Properly truncate upload summaries (img_description) on the...
Brian Wolff [Wed, 16 Nov 2011 19:50:59 +0000 (19:50 +0000)]
(bug 31535; bug 332) Properly truncate upload summaries (img_description) on the php side.

Before it would get truncated when inserted into the 255 byte db field. This is bad as it can leave dangling multi-byte unicode sequences, additionally, since directly after upload we appearently cache the file object, this can result in the comment in the file history table being super-huge.

This also removes the parenthesis in the comment field in the table. Its a table, we don't need to use () to visually separate it from the rest of the page content.

This commit also causes '...' (or the i18n'ed equivalent) to be appended when truncated a comment. Previously that didn't happen. Also I changed it to use a method that doesn't check for '*' as a special value to mean no description. I looked at the toolserver db, and even uploads to enwikipedia from 2002 don't use '*' as special no-description marker.

12 years agoRegister new message key from r103314 for maintenance scripts
Raimond Spekking [Wed, 16 Nov 2011 19:03:43 +0000 (19:03 +0000)]
Register new message key from r103314 for maintenance scripts

12 years agoFix extension URL
Sam Reed [Wed, 16 Nov 2011 16:59:21 +0000 (16:59 +0000)]
Fix extension URL

12 years agoOn errors not using OutputPage, Content-Type header wasn't set,
Platonides [Wed, 16 Nov 2011 16:53:12 +0000 (16:53 +0000)]
On errors not using OutputPage, Content-Type header wasn't set,
although we output localised UTF-8 messaged.

12 years ago* Use WikiPage instead of Article
Alexandre Emsenhuber [Wed, 16 Nov 2011 15:57:56 +0000 (15:57 +0000)]
* Use WikiPage instead of Article
* Create the WikiPage object directly in execute() and pass it to both delete() and deleteFile()
* Reordered parameters of delete() and deleteFile() to be consistent and take both on the WikiPage and User objects (instead of relying on $wgUser); no callers outside of this class
* Fixed deleteFile() to match the behaviour of FileDeleteForm with oldimage parameter
* Pass the User object to getPermissionsError()
* Factorised duplicated code
* Added missing error code to ApiBase (and also a new one)
* Added missing possible error codes (with a new one too)

12 years agoFollow-up r101449 and friends: no need to consider LC rebuild a database update and...
Max Semenik [Wed, 16 Nov 2011 15:21:44 +0000 (15:21 +0000)]
Follow-up r101449 and friends: no need to consider LC rebuild a database update and especially it shouldn't be listed separately for every DB updater

12 years agobug 28643 improvement to serbian variants conversion
Antoine Musso [Wed, 16 Nov 2011 15:12:00 +0000 (15:12 +0000)]
bug 28643 improvement to serbian variants conversion

This patch is a PARTIAL merge of /branches/nikola/phase3 ::

r85224 avoid double conversion when text already use the correct variant
r85239 minor fixes to previous
r85308 documentation (@since 1.18 update to 1.19)
r101359 guessVariant doc + boolean typecast
r101369 tests
r103131 additional test

Test plan:
==========
$ ./phpunit.php --filter LanguageSr
PHPUnit 3.6.3 by Sebastian Bergmann.

Configuration read from /srv/trunk/tests/phpunit/suite.xml

.....

Time: 1 second, Memory: 78.50Mb

OK (5 tests, 19 assertions)
$

12 years agoComments, braces, explicit member variables
Sam Reed [Wed, 16 Nov 2011 13:22:03 +0000 (13:22 +0000)]
Comments, braces, explicit member variables

Remove a couple of unused variables

12 years agoTrim some long lines. Add fullstops
Sam Reed [Wed, 16 Nov 2011 13:18:00 +0000 (13:18 +0000)]
Trim some long lines. Add fullstops

12 years agoFollow-up r103202: removed unused global declaration
Alexandre Emsenhuber [Wed, 16 Nov 2011 13:17:53 +0000 (13:17 +0000)]
Follow-up r103202: removed unused global declaration

12 years agoFill up, and synchronise RELEASE-NOTES-1.18
Sam Reed [Wed, 16 Nov 2011 13:00:56 +0000 (13:00 +0000)]
Fill up, and synchronise RELEASE-NOTES-1.18

12 years agoadd checkbox for listauthors on export form if wgExportAllowListContributors set
Ariel Glenn [Wed, 16 Nov 2011 12:01:58 +0000 (12:01 +0000)]
add checkbox for listauthors on export form if wgExportAllowListContributors set

12 years agoClarify comment in r103019
Roan Kattouw [Wed, 16 Nov 2011 10:37:27 +0000 (10:37 +0000)]
Clarify comment in r103019

12 years agoFollowup r103294, remove a space that got added on the end of the method
John Du Hart [Wed, 16 Nov 2011 04:39:21 +0000 (04:39 +0000)]
Followup r103294, remove a space that got added on the end of the method

12 years agoFollowing r100264, update usages in core
John Du Hart [Wed, 16 Nov 2011 04:37:17 +0000 (04:37 +0000)]
Following r100264, update usages in core

12 years agoRemoved the 'eclipse helper' bit on top of every API module
John Du Hart [Wed, 16 Nov 2011 00:17:26 +0000 (00:17 +0000)]
Removed the 'eclipse helper' bit on top of every API module

It's a parctice that dates back to 2006 when the API was first written, and frankly isn't covered by the coding conventions. Same thing with the docblocks, they're all copypasted with some bits changed and don't even make sense if you look at them in the genereated code docs.
I don't feel that any of us depend on this anymore (get a better IDE), so in the inerest of consistancy it's time we said goodbye to it.

12 years agoDeprecated WikiPage::preSaveTransform() in favour of Parser::preSaveTransform() and...
Alexandre Emsenhuber [Tue, 15 Nov 2011 21:46:05 +0000 (21:46 +0000)]
Deprecated WikiPage::preSaveTransform() in favour of Parser::preSaveTransform() and updated callers; added wfDeprecated() call since there are no callers in extensions

12 years agoAdded Article::newFromWikiPage() function to create an appropriate Article object...
Aaron Schulz [Tue, 15 Nov 2011 19:41:32 +0000 (19:41 +0000)]
Added Article::newFromWikiPage() function to create an appropriate Article object from a WikiPage and keep the process cache vars of the later

12 years agoMake wfExpandUrl use wfRemoveDotSegments on the resulting path. This finishes
gicode [Tue, 15 Nov 2011 18:53:20 +0000 (18:53 +0000)]
Make wfExpandUrl use wfRemoveDotSegments on the resulting path.  This finishes
off bug 32168.

Also follow-up r103199 (related) to use isset.

12 years agoRemoved useless constructor, just use parent's one which is identical
Alexandre Emsenhuber [Tue, 15 Nov 2011 18:28:26 +0000 (18:28 +0000)]
Removed useless constructor, just use parent's one which is identical

12 years agoMoved read only check after permissions and block so that the user doesn't think...
Alexandre Emsenhuber [Tue, 15 Nov 2011 18:26:05 +0000 (18:26 +0000)]
Moved read only check after permissions and block so that the user doesn't think the error is temporary in case he doesn't have the permission and the database is in read only mode

12 years ago* Factorise common code in ImagePage::delete() and allow normal page deletion if...
Alexandre Emsenhuber [Tue, 15 Nov 2011 18:08:34 +0000 (18:08 +0000)]
* Factorise common code in ImagePage::delete() and allow normal page deletion if $wgUploadMaintenance is true
* Moved $wgUploadMaintenance check after permissions and read only, so that the user doesn't think the error is temporary if he both doesn't have the permission and $wgUploadMaintenance is true
* Show normal error page when $wgUploadMaintenance and added a message for the error title
* Moved watchlist updating to FileDeletForm::execute(), it has nothing to do in doDelete() (would also be executed for api requests, etc.)
* Added $user parameter to FileDeletForm::doDelete() to pass the user doing the action
* Use WikiPage instead of Article

12 years agoAdd wfAssembleUrl and unit tests. This is the next step towards fixing
gicode [Tue, 15 Nov 2011 17:38:20 +0000 (17:38 +0000)]
Add wfAssembleUrl and unit tests. This is the next step towards fixing
bug 32168.  This function is the inverse of wfParseUrl and is useful when you
need to modify part of a URL and have to put it back together.

Further, with the addition of this function, there is sufficient code in core
to create a proper URI class.

12 years agoFixup for r102997. If you add returns to a profiled function,
Platonides [Tue, 15 Nov 2011 16:35:52 +0000 (16:35 +0000)]
Fixup for r102997. If you add returns to a profiled function,
you should make sure to wfProfileOut on all branches.

12 years agoFollow-up r103179: $handled variable undefined
Platonides [Tue, 15 Nov 2011 16:27:16 +0000 (16:27 +0000)]
Follow-up r103179: $handled variable undefined

12 years agoAddress fixme on r101644 (bug 32325, bug 32263), originally for bug 31822. PHP 5...
Chad Horohoe [Tue, 15 Nov 2011 15:04:36 +0000 (15:04 +0000)]
Address fixme on r101644 (bug 32325, bug 32263), originally for bug 31822. PHP 5.2 below 5.2.7 throws a warning when you try to fopen() in append mode. Fixed by only fwrite()ing to STDIN|STDERR when in cli, use print otherwise (per Tim's suggestion).

People didn't seem to like the idea of bumping the minimum version to 5.2.7 since some distros like being behind the times.

12 years agoThe names for Kashmiri were in Urdu and Hindi. Change to native names per http:/...
Robin Pepermans [Tue, 15 Nov 2011 13:27:14 +0000 (13:27 +0000)]
The names for Kashmiri were in Urdu and Hindi. Change to native names per ks.wikipedia.org/wiki/User_talk:SPQRobin

12 years agoFollowup r102575, recreate export-0.6.xsd copied with export-0.5.xsd history
Sam Reed [Tue, 15 Nov 2011 11:04:00 +0000 (11:04 +0000)]
Followup r102575, recreate export-0.6.xsd copied with export-0.5.xsd history

12 years agoFollowup r102575, delete export-0.6.xsd to create from a copy of export-0.5.xsd
Sam Reed [Tue, 15 Nov 2011 11:02:21 +0000 (11:02 +0000)]
Followup r102575, delete export-0.6.xsd to create from a copy of export-0.5.xsd

12 years ago(bug 32241) Fix flickering behavior in IE. Patch by Lupo. See also r102948
Roan Kattouw [Tue, 15 Nov 2011 09:59:32 +0000 (09:59 +0000)]
(bug 32241) Fix flickering behavior in IE. Patch by Lupo. See also r102948

12 years agoFollow up r102802. Bug 32359
Santhosh Thottingal [Tue, 15 Nov 2011 04:28:34 +0000 (04:28 +0000)]
Follow up r102802. Bug 32359
Use negative sign itself instead of $_[0] since $_ is mixed type.
Add more test cases.

12 years agoFix for r102649
John Du Hart [Tue, 15 Nov 2011 02:42:07 +0000 (02:42 +0000)]
Fix for r102649

12 years agoConvert SpecialBlock to subclass FormSpecialPage
John Du Hart [Tue, 15 Nov 2011 02:25:36 +0000 (02:25 +0000)]
Convert SpecialBlock to subclass FormSpecialPage

Also fixes the problem introduced in r103115

12 years agoChanged new LocalFilePurgeThumbnails hook arguments and updated wmf/swift.php to...
Aaron Schulz [Tue, 15 Nov 2011 02:20:08 +0000 (02:20 +0000)]
Changed new LocalFilePurgeThumbnails hook arguments and updated wmf/swift.php to actually work for archived file thumbs.

12 years agoUpdated core SpecialPages to use new functions introduced in r103111 and r103095
John Du Hart [Tue, 15 Nov 2011 01:34:19 +0000 (01:34 +0000)]
Updated core SpecialPages to use new functions introduced in r103111 and r103095

12 years agoAdding function for checking if the database is in readonly mode
John Du Hart [Tue, 15 Nov 2011 01:19:04 +0000 (01:19 +0000)]
Adding function for checking if the database is in readonly mode
Replacing some code in SpecialPageForm to use these new functions

12 years agoAdded function to SpecialPage to simplify permissions checking in SpecialPage classes.
John Du Hart [Tue, 15 Nov 2011 00:37:38 +0000 (00:37 +0000)]
Added function to SpecialPage to simplify permissions checking in SpecialPage classes.

12 years agoMake sure that the old insertTags of mediawiki.action.edit.js works with each textare...
Derk-Jan Hartman [Mon, 14 Nov 2011 23:28:48 +0000 (23:28 +0000)]
Make sure that the old insertTags of mediawiki.action.edit.js works with each textarea or text input field on a page.

Note. Using input:text, because input[type=text] doesn't return the input's with no type set.

This fixes bug 31682, where Extension:CharInsert wasn't working on upload pages anymore and
bug 31566, where Extension:Proofread's header and footer fields didn't work icw CharInsert

12 years agoAdd isset tests to stuff inside BaseTemplate::getToolbox.
Daniel Friesen [Mon, 14 Nov 2011 21:57:36 +0000 (21:57 +0000)]
Add isset tests to stuff inside BaseTemplate::getToolbox.

12 years agoFix for r102997: forgot to change that variable
Alexandre Emsenhuber [Mon, 14 Nov 2011 21:42:27 +0000 (21:42 +0000)]
Fix for r102997: forgot to change that variable

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Mon, 14 Nov 2011 21:39:03 +0000 (21:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoReverts r102799, followsup r102800 also
Sam Reed [Mon, 14 Nov 2011 21:14:31 +0000 (21:14 +0000)]
Reverts r102799, followsup r102800 also

Logged LoggedUpdateMaintenance did the inserting, the problem was the script was unconditionally run

Added some documentation tooo

12 years ago(bug 19833) Make the searching-for-an-IP-means-you-want-Special:Contributions behavio...
Roan Kattouw [Mon, 14 Nov 2011 20:00:35 +0000 (20:00 +0000)]
(bug 19833) Make the searching-for-an-IP-means-you-want-Special:Contributions behavior configurable. Patch by Olivier Finlay Beaton

12 years agoRemove commented-out variable ApiMain::$mRequest
Roan Kattouw [Mon, 14 Nov 2011 19:44:13 +0000 (19:44 +0000)]
Remove commented-out variable ApiMain::$mRequest

12 years agoFix for r103001: using the object is actually a good idea
Alexandre Emsenhuber [Mon, 14 Nov 2011 18:31:44 +0000 (18:31 +0000)]
Fix for r103001: using the object is actually a good idea

12 years agoUpdate DifferenceEngine::renderNewRevision() to run the 'ArticleViewCustom' hook...
Alexandre Emsenhuber [Mon, 14 Nov 2011 18:28:01 +0000 (18:28 +0000)]
Update DifferenceEngine::renderNewRevision() to run the 'ArticleViewCustom' hook and create a WikiPage object and do "normal wikitext" processing only when really needed

12 years agoSome cleanup to Article::view() and related:
Alexandre Emsenhuber [Mon, 14 Nov 2011 18:05:55 +0000 (18:05 +0000)]
Some cleanup to Article::view() and related:
* Moved the page check if oldid was given from Article::fetchContent() to Article::getOldidIDFromRequest() so that it's done directly when executing Article::view(); this should not happen though for normal view requests since oldid and related are checked in MediaWiki::parseTitle()
* Removed $oldid parameter from Article::fetchContent() and always use the oldid parameter passed either in the constructor or the request; also changed call from Article::loadContent() to Article::fromContent() since the former is now only a redirect to the latter
* Moved the 'read' permission check to the beginning of Article::view() since the Title is now correct directly after calling Article::getOldID()
* Merged the two calls to the parser cache and make WikiPage::isParserCacheUsed() also return true when the latest revision id is given. Article::setOldSubtitle() is still called when the oldid is passed to display the "You are view the current revision of this article".
* Also moved the non-existing page check a bit up to avoid running a good part of useless code when the page doesn't exist
* Merged two calls to Title::quickUserCan( 'edit' ) to set edit sections to false

12 years agofind on Windows is incompatible with *nix
Max Semenik [Mon, 14 Nov 2011 16:53:50 +0000 (16:53 +0000)]
find on Windows is incompatible with *nix

12 years agoFollowup r99224: add message to ApiBase::$messageMap too
Roan Kattouw [Mon, 14 Nov 2011 14:40:55 +0000 (14:40 +0000)]
Followup r99224: add message to ApiBase::$messageMap too

12 years agoAdd Platonides' "add wlexcludeuser to feedwatchlist" patch from bug 25325
Sam Reed [Mon, 14 Nov 2011 14:36:06 +0000 (14:36 +0000)]
Add Platonides' "add wlexcludeuser to feedwatchlist" patch from bug 25325

12 years agoFollowup r102945: $wgFooterIcons too
Roan Kattouw [Mon, 14 Nov 2011 14:08:56 +0000 (14:08 +0000)]
Followup r102945: $wgFooterIcons too

12 years agoUpdated remaining functions executing NewRevisionFromEditComplete hook to use WikiPag...
Alexandre Emsenhuber [Mon, 14 Nov 2011 12:40:14 +0000 (12:40 +0000)]
Updated remaining functions executing NewRevisionFromEditComplete hook to use WikiPage instead of Article

12 years agoFollowup r102910
Sam Reed [Mon, 14 Nov 2011 10:34:23 +0000 (10:34 +0000)]
Followup r102910

Make the link to the MW page https only

12 years agoRevert r102949. Broke tests (undefined variable $_SESSION because session_start(...
Roan Kattouw [Mon, 14 Nov 2011 09:23:58 +0000 (09:23 +0000)]
Revert r102949. Broke tests (undefined variable $_SESSION because session_start() hadn't been called) and is unnecessary because we have DerivativeRequest now

12 years agoFix for r102949: don't delete too much
Roan Kattouw [Mon, 14 Nov 2011 09:16:30 +0000 (09:16 +0000)]
Fix for r102949: don't delete too much

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Mon, 14 Nov 2011 09:16:03 +0000 (09:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoRemove the kok-* codes got added unintentionally in r102891.
Santhosh Thottingal [Mon, 14 Nov 2011 09:15:32 +0000 (09:15 +0000)]
Remove the kok-* codes got added unintentionally in r102891.

12 years ago(bug 29854) Store protocol-relative links twice in the externallinks table, one with...
Roan Kattouw [Mon, 14 Nov 2011 09:13:58 +0000 (09:13 +0000)]
(bug 29854) Store protocol-relative links twice in the externallinks table, one with http: in el_index and once with https: . Modified patch by Brad Jorsch

12 years agoFollowup r101149: make FauxRequest::__construct() use $_SESSION if the session parame...
Roan Kattouw [Mon, 14 Nov 2011 08:40:06 +0000 (08:40 +0000)]
Followup r101149: make FauxRequest::__construct() use $_SESSION if the session parameter isn't given

12 years ago(bug 32241) WikiEditor scrolls the browser and does not insert in IE7, IE8, IE9 if...
Roan Kattouw [Mon, 14 Nov 2011 08:37:38 +0000 (08:37 +0000)]
(bug 32241) WikiEditor scrolls the browser and does not insert in IE7, IE8, IE9 if the textarea doesn't fit on the screen. Patch by Lupo

12 years ago(bug 26909) Add dir parameter for prop= API modules. Modified patch by Umherirrender
Roan Kattouw [Mon, 14 Nov 2011 08:19:55 +0000 (08:19 +0000)]
(bug 26909) Add dir parameter for prop= API modules. Modified patch by Umherirrender

12 years ago(bug 32380) Make get powered by link target protocol-relative
Roan Kattouw [Mon, 14 Nov 2011 08:06:41 +0000 (08:06 +0000)]
(bug 32380) Make get powered by link target protocol-relative

12 years agoBug 32379 - DatabaseError.php is hardcoding http
Sam Reed [Sun, 13 Nov 2011 21:42:57 +0000 (21:42 +0000)]
Bug 32379 - DatabaseError.php is hardcoding http

Also tidy up a couple of returns (per others in method, and/or parents)

12 years agoFixup for r102875 parse error.
Platonides [Sun, 13 Nov 2011 19:58:24 +0000 (19:58 +0000)]
Fixup for r102875 parse error.
The post-commit hook is *again* not working...

12 years agoPer Nikerabbit, follow-up r102187: added RELEASE-NOTES entry about the fact that...
Alexandre Emsenhuber [Sun, 13 Nov 2011 14:11:08 +0000 (14:11 +0000)]
Per Nikerabbit, follow-up r102187: added RELEASE-NOTES entry about the fact that getUserPermissionsErrors and getUserPermissionsErrorsExpensive hooks are now called when checking for 'read' permission

12 years agoCorrect the name of Sanskrit. Follow-up 102889.
Santhosh Thottingal [Sun, 13 Nov 2011 12:50:20 +0000 (12:50 +0000)]
Correct the name of Sanskrit. Follow-up 102889.

12 years agoLocalise numbers in TOC added in r102334
Robin Pepermans [Sun, 13 Nov 2011 12:46:53 +0000 (12:46 +0000)]
Localise numbers in TOC added in r102334

12 years agoOops, missed to notice the missed <?php. Reverting.
Santhosh Thottingal [Sun, 13 Nov 2011 12:41:33 +0000 (12:41 +0000)]
Oops, missed to notice the missed <?php. Reverting.

12 years agoRemoved transaction in saveOptions(). No reason was given for it and it could break...
Aaron Schulz [Sun, 13 Nov 2011 12:35:28 +0000 (12:35 +0000)]
Removed transaction in saveOptions(). No reason was given for it and it could break any callers that have transactions.

12 years agoCorrect the name of Sanskrit Language.
Santhosh Thottingal [Sun, 13 Nov 2011 12:22:10 +0000 (12:22 +0000)]
Correct the name of Sanskrit Language.
Bug 32393

12 years agoAdded rollback-related comment to nextSequenceValue()
Aaron Schulz [Sun, 13 Nov 2011 11:28:56 +0000 (11:28 +0000)]
Added rollback-related comment to nextSequenceValue()

12 years agoRefactored EditPage::getPreloadedText():
Alexandre Emsenhuber [Sun, 13 Nov 2011 09:12:03 +0000 (09:12 +0000)]
Refactored EditPage::getPreloadedText():
* Use WikiPage instead of Article (avoids conflicting with oldid url parameter)
* Use getRedirectTarget() instead of creating a new Title with the content of the page
* Changed userCanRead() calls to userCan( 'read' )
* Use "if ( something ) return;" instead of nesting if checks

12 years agoAddress comments in r97628
Niklas Laxström [Sun, 13 Nov 2011 08:58:38 +0000 (08:58 +0000)]
Address comments in r97628

12 years agoRemoved usage of $wgUser in block and unblock processing:
Alexandre Emsenhuber [Sun, 13 Nov 2011 07:25:56 +0000 (07:25 +0000)]
Removed usage of $wgUser in block and unblock processing:
* Made HTMLFormField pass the HTMLForm object to the validation and filter callbacks (so that they can get a context)
* Added new parameter to SpecialBlock::checkUnblockSelf() to pass the user doing the request
* SpecialBlock::processForm() and SpecialUnblock::processUnblock() now require a context as second parameter; added SpecialBlock::processUIForm() and SpecialUnblock::processUIUnblock() as adaptators from HTMLForm as second parameter to context

12 years agoThis patch fixes rev. 102575.
Diederik van Liere [Sun, 13 Nov 2011 01:50:24 +0000 (01:50 +0000)]
This patch fixes rev. 102575.

12 years agoDocument $wgGroupPermissions better, including per-NS stuff
Aaron Schulz [Sat, 12 Nov 2011 22:36:47 +0000 (22:36 +0000)]
Document $wgGroupPermissions better, including per-NS stuff

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Sat, 12 Nov 2011 21:52:22 +0000 (21:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoComment tweak on MediaWikiParserTest and make ResourceLoaderTest extend MediaWikiTestCase
Chad Horohoe [Sat, 12 Nov 2011 21:32:39 +0000 (21:32 +0000)]
Comment tweak on MediaWikiParserTest and make ResourceLoaderTest extend MediaWikiTestCase

12 years agoMoved methods around to group them by functionnality
Alexandre Emsenhuber [Sat, 12 Nov 2011 13:47:17 +0000 (13:47 +0000)]
Moved methods around to group them by functionnality

12 years agoPer Nikerabbit, fix undefined variable notice from r102851
Alexandre Emsenhuber [Sat, 12 Nov 2011 12:13:08 +0000 (12:13 +0000)]
Per Nikerabbit, fix undefined variable notice from r102851

12 years ago* Renamed member variables to begin with a lower case
Alexandre Emsenhuber [Sat, 12 Nov 2011 09:57:47 +0000 (09:57 +0000)]
* Renamed member variables to begin with a lower case
* Moved constant definitions from the constructor to the class definition
* Removed default values from the class definition for members that are always set in the constructor

12 years agoAllow extensions to add post-update maintenance scripts
Roan Kattouw [Sat, 12 Nov 2011 09:55:28 +0000 (09:55 +0000)]
Allow extensions to add post-update maintenance scripts

12 years agoUse WikiPage instead of Article
Alexandre Emsenhuber [Sat, 12 Nov 2011 07:36:41 +0000 (07:36 +0000)]
Use WikiPage instead of Article

12 years agoUse the local user to get time offset and format, also removed wfTimestamp() call...
Alexandre Emsenhuber [Sat, 12 Nov 2011 07:30:25 +0000 (07:30 +0000)]
Use the local user to get time offset and format, also removed wfTimestamp() call since this is already done in the function

12 years agoFU r102073:
Aaron Schulz [Fri, 11 Nov 2011 22:14:21 +0000 (22:14 +0000)]
FU r102073:
* (bug 32367) Fixed SpecialMovePage to not call wfLocalFile() on a non file title and expect an actual File back. Previously "worked" due to an old file title checking loophole (File objects with non File: titles).
* Use File::normalizeTitle() in some more functions that were still doing their own incomplete normalization.
* Updated FileRepo::newFile() docs to reflect that it can return null; wfLocalFile() docs already mentioned this.

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Fri, 11 Nov 2011 20:38:26 +0000 (20:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoMake commafy support negative numbers too,
Santhosh Thottingal [Fri, 11 Nov 2011 17:23:12 +0000 (17:23 +0000)]
Make commafy support negative numbers too,
Add test cases.
Ref Bug 32359  and Followup r97793

12 years agoSame for the getPostDatabaseUpdateMaintenance
Sam Reed [Fri, 11 Nov 2011 17:06:03 +0000 (17:06 +0000)]
Same for the getPostDatabaseUpdateMaintenance

We only need to run them once

12 years agoFollowup r102799, unconditionally running them anyway also isn't much use
Sam Reed [Fri, 11 Nov 2011 16:58:09 +0000 (16:58 +0000)]
Followup r102799, unconditionally running them anyway also isn't much use

12 years agoNaff all point varying on $this->updateRowExists when we never bloody insert to that...
Sam Reed [Fri, 11 Nov 2011 16:47:48 +0000 (16:47 +0000)]
Naff all point varying on $this->updateRowExists when we never bloody insert to that database (more of these to come as I cleanup the updater)

12 years agoFollowup r102785, fix wrong index order in tables.sql. The patches are fine
Roan Kattouw [Fri, 11 Nov 2011 16:37:38 +0000 (16:37 +0000)]
Followup r102785, fix wrong index order in tables.sql. The patches are fine

12 years agoDon't pass the count parameter in rawParams() otherwise {{PLURAL:}} won't work (spott...
Alexandre Emsenhuber [Fri, 11 Nov 2011 16:09:34 +0000 (16:09 +0000)]
Don't pass the count parameter in rawParams() otherwise {{PLURAL:}} won't work (spotted while looking at r102794 but not related to that rev)