Follow up r102802. Bug 32359

Use negative sign itself instead of $_[0] since $_ is mixed type.
Add more test cases.

diff --git a/languages/Language.php b/languages/Language.php
index 48fd882..84e9cbd 100644 (file)
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -2725,7 +2725,7 @@ class Language {
                        $sign = "";
                        if ( intval( $_ ) < 0 ) {
                                // For negative numbers apply the algorithm like positive number and add sign.
-                               $sign =   $_[0];
+                               $sign =  "-";
                                $_ = substr( $_,1 );
                        }
                        $numberpart = array();

diff --git a/tests/phpunit/languages/LanguageMlTest.php b/tests/phpunit/languages/LanguageMlTest.php
index c659e5c..45091db 100644 (file)
--- a/tests/phpunit/languages/LanguageMlTest.php
+++ b/tests/phpunit/languages/LanguageMlTest.php
@@ -28,5 +28,7 @@ class LanguageMlTest extends MediaWikiTestCase {
                $this->assertEquals( '.12345', $this->lang->formatNum( '.12345' ) );
                $this->assertEquals( '-12,00,000', $this->lang->formatNum( '-1200000' ) );
                $this->assertEquals( '-98', $this->lang->formatNum( '-98' ) );
+               $this->assertEquals( '-98', $this->lang->formatNum( -98 ) );
+               $this->assertEquals( '-1,23,45,678', $this->lang->formatNum( -12345678 ) );
        }
 }