Use the ?: shortcut from PHP 5.3 where it makes sense
authorThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Wed, 9 Jan 2019 15:52:38 +0000 (16:52 +0100)
committerUmherirrender <umherirrender_de.wp@web.de>
Sat, 12 Jan 2019 21:56:41 +0000 (21:56 +0000)
Change-Id: Ieff70f23b19f0be3670c4ed3e2a5c30ef3792d7f

languages/Language.php
maintenance/includes/BackupDumper.php
maintenance/parse.php

index 1c2e4f1..ef9137d 100644 (file)
@@ -1421,7 +1421,7 @@ class Language {
                                case 'g':
                                        $usedHour = true;
                                        $h = substr( $ts, 8, 2 );
-                                       $num = $h % 12 ? $h % 12 : 12;
+                                       $num = $h % 12 ?: 12;
                                        break;
                                case 'G':
                                        $usedHour = true;
@@ -1430,7 +1430,7 @@ class Language {
                                case 'h':
                                        $usedHour = true;
                                        $h = substr( $ts, 8, 2 );
-                                       $num = sprintf( '%02d', $h % 12 ? $h % 12 : 12 );
+                                       $num = sprintf( '%02d', $h % 12 ?: 12 );
                                        break;
                                case 'H':
                                        $usedHour = true;
index 4c2b64c..31fe33f 100644 (file)
@@ -358,9 +358,7 @@ abstract class BackupDumper extends Maintenance {
        function backupServer() {
                global $wgDBserver;
 
-               return $this->server
-                       ? $this->server
-                       : $wgDBserver;
+               return $this->server ?: $wgDBserver;
        }
 
        function reportPage() {
index f01d8f5..43bbca1 100644 (file)
@@ -117,9 +117,7 @@ class CLIParser extends Maintenance {
         * @return Title
         */
        protected function getTitle() {
-               $title = $this->getOption( 'title' )
-                       ? $this->getOption( 'title' )
-                       : 'CLIParser';
+               $title = $this->getOption( 'title' ) ?: 'CLIParser';
 
                return Title::newFromText( $title );
        }