Fix MySQLism in populateRevisionLength.php 1.31.0-rc.0
authorBrad Jorsch <bjorsch@wikimedia.org>
Tue, 1 May 2018 13:24:36 +0000 (09:24 -0400)
committerAnomie <bjorsch@wikimedia.org>
Tue, 1 May 2018 16:25:38 +0000 (16:25 +0000)
Use addQuotes() to make a quoted string instead of MySQL's nonstandard
use of double-quotes.

Change-Id: Ie2d017a33b694417a3db140b2798a8d55f911985
(cherry picked from commit 5e6efe18d01f64f2c9a0a8bcb213ffe30999530f)

maintenance/populateRevisionLength.php

index ffa4ff7..dcb89d1 100644 (file)
@@ -103,7 +103,7 @@ class PopulateRevisionLength extends LoggedUpdateMaintenance {
                                                "{$prefix}_len IS NULL",
                                                $dbr->makeList( [
                                                        "{$prefix}_len = 0",
-                                                       "{$prefix}_sha1 != \"phoiac9h4m842xq45sp7s6u21eteeq1\"", // sha1( "" )
+                                                       "{$prefix}_sha1 != " . $dbr->addQuotes( 'phoiac9h4m842xq45sp7s6u21eteeq1' ), // sha1( "" )
                                                ], IDatabase::LIST_AND )
                                        ], IDatabase::LIST_OR )
                                ],