UsersPager: Use CSS-based parentheses
authorRoan Kattouw <roan.kattouw@gmail.com>
Fri, 19 Apr 2019 21:44:27 +0000 (14:44 -0700)
committerRoan Kattouw <roan.kattouw@gmail.com>
Tue, 23 Apr 2019 17:32:22 +0000 (10:32 -0700)
Tell Linker::userToolLinks() and Linker::userToolLinksRedContribs()
to omit parentheses, and load the CSS that fills them in.

Change-Id: Ie979537abed226e945cf1918b3ee240ae78ee24e

includes/specials/SpecialActiveUsers.php
includes/specials/SpecialListUsers.php
includes/specials/pagers/ActiveUsersPager.php
includes/specials/pagers/UsersPager.php

index f52a6f3..7995e3e 100644 (file)
@@ -67,6 +67,7 @@ class SpecialActiveUsers extends SpecialPage {
                                Html::rawElement( 'ul', [], $usersBody ) .
                                $pager->getNavigationBar()
                        );
+                       $out->addModuleStyles( 'mediawiki.interface.helpers.styles' );
                } else {
                        $out->addWikiMsg( 'activeusers-noresult' );
                }
index 7aef4ae..f8aac32 100644 (file)
@@ -59,7 +59,9 @@ class SpecialListUsers extends IncludableSpecialPage {
                        $s .= $this->msg( 'listusers-noresult' )->parseAsBlock();
                }
 
-               $this->getOutput()->addHTML( $s );
+               $out = $this->getOutput();
+               $out->addHTML( $s );
+               $out->addModuleStyles( 'mediawiki.interface.helpers.styles' );
        }
 
        /**
index 39da076..368c6d1 100644 (file)
@@ -225,7 +225,18 @@ class ActiveUsersPager extends UsersPager {
                $userName = $row->user_name;
 
                $ulinks = Linker::userLink( $row->user_id, $userName );
-               $ulinks .= Linker::userToolLinks( $row->user_id, $userName );
+               $ulinks .= Linker::userToolLinks(
+                       $row->user_id,
+                       $userName,
+                       // Should the contributions link be red if the user has no edits (using default)
+                       false,
+                       // Customisation flags (using default 0)
+                       0,
+                       // User edit count (using default)
+                       null,
+                       // do not wrap the message in parentheses (CSS will provide these)
+                       false
+               );
 
                $lang = $this->getLanguage();
 
index 8dd6e23..4453772 100644 (file)
@@ -178,7 +178,9 @@ class UsersPager extends AlphabeticPager {
                $ulinks .= Linker::userToolLinksRedContribs(
                        $row->user_id,
                        $userName,
-                       (int)$row->edits
+                       (int)$row->edits,
+                       // don't render parentheses in HTML markup (CSS will provide)
+                       false
                );
 
                $lang = $this->getLanguage();