Preferences: Remove href="#" from stub threshold sample link

* Prevents the sample link from being focusable and selectable via
  keyboard navigation.
* Prevents the sample link from being clicked, which would switch
  to the first preferences tab and scroll to the top, unhelpfully.
* Since 4f8967672d an <a> without an href also has cursor:pointer on
  hover.

Change-Id: I679e277d17dc679177c29d557806c9a9e91c6703

diff --git a/includes/preferences/DefaultPreferencesFactory.php b/includes/preferences/DefaultPreferencesFactory.php
index 512a6b3..ea78b68 100644 (file)
--- a/includes/preferences/DefaultPreferencesFactory.php
+++ b/includes/preferences/DefaultPreferencesFactory.php
@@ -843,7 +843,7 @@ class DefaultPreferencesFactory implements PreferencesFactory {
                        'options' => $stubThresholdOptions,
                        // This is not a raw HTML message; label-raw is needed for the manual <a></a>
                        'label-raw' => $l10n->msg( 'stub-threshold' )->rawParams(
-                               '<a href="#" class="stub">' .
+                               '<a class="stub">' .
                                $l10n->msg( 'stub-threshold-sample-link' )->parse() .
                                '</a>' )->parse(),
                ];