Follows-up
e9b9e4df7a5, which started using target=test as reserved for
Special:JavaScriptTest. However that conflicted with this.
Without this change, the unit tests fail if the MediaWiki install has
$wgEnableJavaScriptTest enabled.
Change-Id: I471017e7aedb74dddb4dc18ee4e89c1706ff09b5
$resourceLoader = $context->getResourceLoader();
$target = $context->getRequest()->getVal( 'target', 'desktop' );
- // Bypass target filter if this request is from a unit test context. To prevent misuse in
- // production, this is only allowed if testing is enabled server-side.
+ // Bypass target filter if this request is Special:JavaScriptTest.
+ // To prevent misuse in production, this is only allowed if testing is enabled server-side.
$byPassTargetFilter = $this->getConfig()->get( 'EnableJavaScriptTest' ) && $target === 'test';
$out = '';
'modules' => 'startup',
'only' => 'scripts',
'skin' => 'vector',
- 'target' => 'test',
+ 'target' => 'phpunit',
) );
$ctx = $this->getMockBuilder( 'ResourceLoaderContext' )
->setConstructorArgs( array( $resourceLoader, $request ) )
protected $styles = '';
protected $skipFunction = null;
protected $isRaw = false;
- protected $targets = array( 'test' );
+ protected $targets = array( 'phpunit' );
public function __construct( $options = array() ) {
foreach ( $options as $key => $value ) {