C. Scott Ananian [Fri, 26 Oct 2018 15:14:01 +0000 (11:14 -0400)]
Deprecate OutputPage::parse() and OutputPage::parseInline()
The OutputPage::parse() and OutputPage::parseInline() methods behave
misleadingly different from the OutputPage::addWikitext*() methods:
they don't tidy their output, they have different defaults for
interface/content language selection, and they (sometimes) add
wrapper divs. Deprecate these and add new methods with tidy output,
clear language selection, and consistent defaults:
OutputPage::parseAsContent(), OutputPage::parseAsInterface(),
and OutputPage::parseInlineAsInterface().
Unify the implementation of the parse* methods with the addWikiText*
methods, to reduce the likelihood that the behavior will diverge again
in the future.
Bug: T198214
Change-Id: Ica79c2acbc542ef37f971c0be2582ae771a23bd0
jenkins-bot [Mon, 29 Oct 2018 18:55:22 +0000 (18:55 +0000)]
Merge "Fix OutputPage::parseInternal() by stripping <div> wrapper"
jenkins-bot [Mon, 29 Oct 2018 01:56:40 +0000 (01:56 +0000)]
Merge "resourceloader: ResourceLoaderGetConfigVars is passed skin"
jenkins-bot [Mon, 29 Oct 2018 00:30:13 +0000 (00:30 +0000)]
Merge "Avoid using return value of IDatabase::insert()"
jenkins-bot [Sun, 28 Oct 2018 23:10:53 +0000 (23:10 +0000)]
Merge "Create JobQueueEnqueueUpdate class to call JobQueueGroup::pushLazyJobs()"
Aaron Schulz [Wed, 24 Oct 2018 19:28:02 +0000 (12:28 -0700)]
Create JobQueueEnqueueUpdate class to call JobQueueGroup::pushLazyJobs()
This assures that MergeableUpdate tasks that lazy push job will actually
have those jobs run instead of being added after the lone callback update
to call JobQueueGroup::pushLazyJobs() already ran.
This also makes it more obvious that push will happen, since a mergeable
update is added each time lazyPush() is called and a job is buffered,
rather than rely on some magic callback enqueued into DeferredUpdates at
just the right point in multiple entry points.
Bug: T207809
Change-Id: I13382ef4a17a9ba0fd3f9964b8c62f564e47e42d
Aaron Schulz [Fri, 26 Oct 2018 22:42:26 +0000 (15:42 -0700)]
Avoid using return value of IDatabase::insert()
Change-Id: I5992e4f03cd522b25607947291795d1da60d0291
jenkins-bot [Sun, 28 Oct 2018 21:42:02 +0000 (21:42 +0000)]
Merge "Avoid broken markup due to conversion table DB queries in Installer:parse()"
Translation updater bot [Sun, 28 Oct 2018 20:54:10 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If2370cd24814a27fae6bbb7d33a2074c97740df6
Aaron Schulz [Sat, 27 Oct 2018 23:41:33 +0000 (16:41 -0700)]
Avoid broken markup due to conversion table DB queries in Installer:parse()
Bug: T207979
Change-Id: I6a196a64865533a073fadc4a07f5627b67924921
jenkins-bot [Sat, 27 Oct 2018 21:33:07 +0000 (21:33 +0000)]
Merge "Deprecate hacky wfSplitWikiID() method"
Aaron Schulz [Sat, 27 Oct 2018 14:34:52 +0000 (07:34 -0700)]
Make UserEditCountUpdate faster by using auto-commit mode
Bug: T202715
Change-Id: I92c08694cb5e1c367809439cff42e33a56ff9878
Translation updater bot [Sat, 27 Oct 2018 20:43:10 +0000 (22:43 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib268ee41778efe523367bc2c6aaeecafd56efc85
jenkins-bot [Sat, 27 Oct 2018 05:27:15 +0000 (05:27 +0000)]
Merge "API: Set robots noindex,nofollow on HTML output"
Aaron Schulz [Sun, 21 Oct 2018 07:47:26 +0000 (00:47 -0700)]
Deprecate hacky wfSplitWikiID() method
Change-Id: I59095ee7cc39f634d124fa711ec01a5a5d188d23
jenkins-bot [Sat, 27 Oct 2018 04:03:43 +0000 (04:03 +0000)]
Merge "resoureloader: Restore support for plain callbacks in mediawiki.base's RLQ"
GeoffreyT2000 [Sun, 25 Mar 2018 22:14:06 +0000 (15:14 -0700)]
Increment edit count for all page moves
The user_editcount field should be incremented for all page moves, not just those done using Special:MovePage. Also, if talk pages and/or subpages are moved along with the base page, they will all be included in the edit count.
Bug: T195550
Change-Id: If75a45e4404ca7162b59bf85fa62a996383658b9
Timo Tijhof [Fri, 26 Oct 2018 21:33:26 +0000 (14:33 -0700)]
resoureloader: Restore support for plain callbacks in mediawiki.base's RLQ
Follows-up
dec800968e, which moved the processing of callbacks that require
'modules' from startup.js to mediawiki.base.js.
In doing so, it made an incorrect assumption. It assumed that the simple
signature of RLQ.push(Function) is not needed after 'mediawiki.base' loads.
It is true that RLQ.push() is mostly an internal interface, and we only
use it from within the HTML output, and that once the async pipeline has
finished and startup.js has processed the simple callbacks, only calls with
secondary signatures remain in the queue.
But, while it is true that we don't use RLQ.push() outside the HTML, it is
not true that the HTML will fully load and execute inline scripts before
any of the async scripts execute. As such, the call to RLQ.push() in the
HTML footer was sometimes being ignored because 'mediawiki.base' had already
loaded by now.
Bug: T208093
Change-Id: I25012a2c6f41968b1b4f85614a3bc0416512d530
jenkins-bot [Fri, 26 Oct 2018 20:48:49 +0000 (20:48 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Fri, 26 Oct 2018 20:32:24 +0000 (20:32 +0000)]
Merge "Move user_editcount updates to a mergeable deferred update"
jenkins-bot [Fri, 26 Oct 2018 20:20:37 +0000 (20:20 +0000)]
Merge "rdbms: add transaction comment to IDatabase::masterPosWait()"
jenkins-bot [Fri, 26 Oct 2018 20:20:32 +0000 (20:20 +0000)]
Merge "rdbms: fix connection reuse logic in LoadBalancer for postgres"
Translation updater bot [Fri, 26 Oct 2018 19:55:34 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If9e3c1bf47afc4ee0f0c0afacebf3e32df62fb8c
C. Scott Ananian [Fri, 26 Oct 2018 14:05:34 +0000 (10:05 -0400)]
Fix OutputPage::parseInternal() by stripping <div> wrapper
We should probably strip the <div> wrapper in OutputPage::parse() as
well: this behavior was added in 1.30, but it only applies when
$interface is false. However, that requires a more careful audit
(a lot more places call parse() than parseInline()) and so I'll defer
that for now.
Change-Id: Iad5412f03af29c04deb653969dd71f6c86f0ae50
Zoranzoki21 [Fri, 26 Oct 2018 13:33:53 +0000 (13:33 +0000)]
.gitignore: Fix .vscode
.vscode is directory
Change-Id: I82d1da1b51b4bd32423ad0bb70d30df109fae1ae
jenkins-bot [Fri, 26 Oct 2018 10:50:38 +0000 (10:50 +0000)]
Merge "RCFilters: Apply same distance to FilterItemHighlightButtons as other elements"
jenkins-bot [Fri, 26 Oct 2018 10:50:33 +0000 (10:50 +0000)]
Merge "RCFilters: Cleanup 'Namespaces' dropdown borders appearance"
jenkins-bot [Fri, 26 Oct 2018 03:04:20 +0000 (03:04 +0000)]
Merge "Remove unnecessary, unoptimized, unused overview SVG"
Tim Starling [Thu, 25 Oct 2018 23:14:15 +0000 (16:14 -0700)]
Fix use of non-existent variable Parser::$config
Fix bug from Ib4394f370cb561ccf195338a1c2e9e465dcb3dc3
Add test.
Bug: T208000
Change-Id: Ia81cca1b64afef2af3cb8dff19719a7f0de9d306
Volker E [Thu, 25 Oct 2018 22:59:17 +0000 (15:59 -0700)]
RCFilters: Apply same distance to FilterItemHighlightButtons as other elements
FilterItemHighlightButtons have lost vertical alignment with
“Highlight results”. This patch reintroduces it.
Change-Id: If5578564efced5f0ba4d3ca7ed3d6787b5b0ce3a
Aaron Schulz [Mon, 22 Oct 2018 22:58:02 +0000 (15:58 -0700)]
Move user_editcount updates to a mergeable deferred update
This should reduce excess contention and lock timeouts.
Previously, it used a pre-commit hook which ran just before the
end of the DB transaction round.
Also removed unused User::incEditCountImmediate() method.
Bug: T202715
Depends-on: I6d239a5ea286afb10d9e317b2ee1436de60f7e4f
Depends-on: I0ad3d17107efc7b0e59f1dd54d5733cd1572a2b7
Change-Id: I0d6d7ddd91bbb21995142808248d162e05696d47
Aaron Schulz [Tue, 23 Oct 2018 04:08:44 +0000 (21:08 -0700)]
rdbms: add transaction comment to IDatabase::masterPosWait()
Change-Id: I95aa3b678b76cd06439d1feaba7f09a9c13f8931
Volker E [Thu, 25 Oct 2018 22:06:56 +0000 (15:06 -0700)]
RCFilters: Cleanup 'Namespaces' dropdown borders appearance
Cleaning-up by
- adding border only between namespace and talk options
- adding namespace border on all but the first occurrence
Change-Id: Icfc87757deda9b7655c4ea5c919b5c2f2e2ae09e
jenkins-bot [Thu, 25 Oct 2018 21:50:51 +0000 (21:50 +0000)]
Merge "Clear the title cache in MutableRevisionRecordTest"
jenkins-bot [Thu, 25 Oct 2018 21:45:32 +0000 (21:45 +0000)]
Merge "Make testFormatValueRestrictions() account for $wgArticlePath to avoid failures"
jenkins-bot [Thu, 25 Oct 2018 21:45:27 +0000 (21:45 +0000)]
Merge "Move timing code out of the try/catch in doPostOutputShutdown()"
jenkins-bot [Thu, 25 Oct 2018 21:27:08 +0000 (21:27 +0000)]
Merge "Silence transaction profiler master queries notices for rollback"
jenkins-bot [Thu, 25 Oct 2018 21:17:19 +0000 (21:17 +0000)]
Merge "rdbms: remove duplicate @params in IDatabase::select()"
jenkins-bot [Thu, 25 Oct 2018 21:17:09 +0000 (21:17 +0000)]
Merge "filerepo: Inject the WAN cache info FileRepo instances"
jenkins-bot [Thu, 25 Oct 2018 21:17:04 +0000 (21:17 +0000)]
Merge "Remove unused fields in ForeignDBViaLBRepo"
jenkins-bot [Thu, 25 Oct 2018 21:16:59 +0000 (21:16 +0000)]
Merge "rdbms: Use "mixed" type for $profiler field in LoadBalancer"
Aaron Schulz [Thu, 25 Oct 2018 04:31:58 +0000 (21:31 -0700)]
Clear the title cache in MutableRevisionRecordTest
Also do so in various other test classes.
Follows-up
170c49d61cb8. Fixes Travis CI regression:
> 1) MediaWiki\Tests\Revision\MutableRevisionRecordTest::testSetGetPageId
> Failed asserting that 2 is identical to 0.
> tests/phpunit/includes/Revision/MutableRevisionRecordTest.php:129
Change-Id: I41c8bda8e620ebe7608a393d81f3b0f13af68ba7
Aaron Schulz [Thu, 25 Oct 2018 03:34:41 +0000 (20:34 -0700)]
Make testFormatValueRestrictions() account for $wgArticlePath to avoid failures
Follows-up
170c49d61cb84411.
Change-Id: I37a57b5ece939c5743b7d08d02ce41c71daee5eb
Aaron Schulz [Sun, 21 Oct 2018 12:07:44 +0000 (05:07 -0700)]
filerepo: Inject the WAN cache info FileRepo instances
Also fixed some intellij IDEA warnings.
Change-Id: I667ed7ef9b49c1da1c8c7c9914daadb7c74b3c79
Aaron Schulz [Wed, 24 Oct 2018 11:05:41 +0000 (04:05 -0700)]
rdbms: Use "mixed" type for $profiler field in LoadBalancer
Change-Id: I8d110d0420a155bb62f4212933d9de2562dc7661
Translation updater bot [Thu, 25 Oct 2018 20:16:19 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I67923401760c77676ed4e674170335333ac15d15
jenkins-bot [Thu, 25 Oct 2018 19:30:22 +0000 (19:30 +0000)]
Merge "Fix code style in EmailNotification.php"
Alangi Derick [Tue, 23 Oct 2018 13:50:51 +0000 (14:50 +0100)]
Fix code style in EmailNotification.php
Code style fix for namespace "use" statement.
Change-Id: I0755481f640aae535c8328824812e25db467e528
jenkins-bot [Thu, 25 Oct 2018 17:49:09 +0000 (17:49 +0000)]
Merge "MailAddress->toString(): Reduce complexity by inverting ifs"
Reedy [Sat, 20 Oct 2018 22:31:00 +0000 (23:31 +0100)]
MailAddress->toString(): Reduce complexity by inverting ifs
Change-Id: I5185c0231a0944f36d960211e78cf36273c94d52
Aaron Schulz [Thu, 25 Oct 2018 16:22:30 +0000 (09:22 -0700)]
Move timing code out of the try/catch in doPostOutputShutdown()
Change-Id: Idc24fdaff5bbcb98445cc4dee8c94cc75cd00573
Aaron Schulz [Thu, 25 Oct 2018 15:34:39 +0000 (08:34 -0700)]
rdbms: avoid transaction status errors from ping() in rollback()
Change-Id: I38658cbf90518d9818824674da371637db15e156
Brad Jorsch [Thu, 25 Oct 2018 13:31:31 +0000 (09:31 -0400)]
API: Set robots noindex,nofollow on HTML output
There's probably not much benefit in search engines indexing the API
auto-generated help or various random "format=jsonfm" outputs.
On Wikimedia wikis we already have a robots.txt entry denying indexing
of everything under /w/, which includes api.php.
Bug: T207818
Change-Id: I196d401eeb5fcf49844265df41ad3cce83ffdcdf
jenkins-bot [Thu, 25 Oct 2018 04:43:50 +0000 (04:43 +0000)]
Merge "WikiPage: Truncate redirect fragments before inserting them into the DB"
jenkins-bot [Thu, 25 Oct 2018 03:13:49 +0000 (03:13 +0000)]
Merge "RCFilters: Fix centering of "no results" message"
Roan Kattouw [Thu, 25 Oct 2018 00:50:47 +0000 (17:50 -0700)]
RCFilters: Fix centering of "no results" message
Was caused by a stray margin-right rule that applied to the wrong divs,
and wasn't needed anyway.
Bug: T207808
Change-Id: Ib6cf518653fbadb0c7d67d6a175b4af92c8f8d87
Follows-Up: I76fec57ff237ba02afefcea28916d8348bac9b0e
Roan Kattouw [Thu, 25 Oct 2018 00:09:59 +0000 (17:09 -0700)]
WikiPage: Truncate redirect fragments before inserting them into the DB
The rd_fragment field is 255 bytes wide, but there is no limit on how
long title fragments can be. We don't want to let the database silently
truncate the fragment for us, because that can result in invalid UTF-8.
Instead, truncate it before insertion in a UTF-8-aware way.
Bug: T207876
Change-Id: I12745f3f4c174eaced56d80f3661a71d0e5637e6
jenkins-bot [Wed, 24 Oct 2018 23:35:56 +0000 (23:35 +0000)]
Merge "composer.json, require ext-fileinfo"
Kunal Mehta [Wed, 24 Oct 2018 22:39:53 +0000 (15:39 -0700)]
Disable $wgEnableImageWhitelist by default
This opens up a hole for administrators to load images from external resources,
potentially leaking user's private information to external servers (IP address,
User-Agent, etc.).
Change-Id: Ie780637b292493e664e4d54671a5bb81046106f4
jenkins-bot [Wed, 24 Oct 2018 22:14:03 +0000 (22:14 +0000)]
Merge "Use a pre-commit hook for change_tag_def count updates"
jenkins-bot [Wed, 24 Oct 2018 22:13:06 +0000 (22:13 +0000)]
Merge "Hard deprecate functionality replaced with random_bytes()"
jenkins-bot [Wed, 24 Oct 2018 22:13:00 +0000 (22:13 +0000)]
Merge "Hard deprecate non-tidy OutputPage::addWikiText() method"
jenkins-bot [Wed, 24 Oct 2018 22:09:54 +0000 (22:09 +0000)]
Merge "RELEASE-NOTES-1.33: Note new Partial Blocks feature flag"
jenkins-bot [Wed, 24 Oct 2018 21:58:04 +0000 (21:58 +0000)]
Merge "Use PHP 7 '??' operator instead of if-then-else"
addshore [Mon, 24 Sep 2018 08:25:53 +0000 (09:25 +0100)]
composer.json, require ext-fileinfo
PHPVersionCheck requires fileinfo be installed for mime_content_type
Change-Id: Iea7d2c7842c770e77c05265d4f4b08b17f9ab71f
jenkins-bot [Wed, 24 Oct 2018 21:17:02 +0000 (21:17 +0000)]
Merge "Fix PHPDoc type for instance variables and methods"
Aaron Schulz [Wed, 24 Oct 2018 21:09:41 +0000 (14:09 -0700)]
Use a pre-commit hook for change_tag_def count updates
Bug: T207881
Change-Id: I3000f14d0e49482b0c90ffcfc494211fbc198a20
jenkins-bot [Wed, 24 Oct 2018 20:59:58 +0000 (20:59 +0000)]
Merge "Minor cleanup of languages/ConverterRule.php"
Moriel Schottlender [Wed, 24 Oct 2018 20:44:00 +0000 (13:44 -0700)]
RELEASE-NOTES-1.33: Note new Partial Blocks feature flag
Change-Id: Ibc7a3265f9c3f067e280f9f5e17a2b16b2bed69b
jenkins-bot [Wed, 24 Oct 2018 20:35:06 +0000 (20:35 +0000)]
Merge "Tidy Message::parseAsBlock() by enabling tidy in MessageCache"
jenkins-bot [Wed, 24 Oct 2018 20:35:01 +0000 (20:35 +0000)]
Merge "extraParserTests.txt: Fix typo"
C. Scott Ananian [Tue, 25 Sep 2018 14:05:55 +0000 (10:05 -0400)]
Hard deprecate non-tidy OutputPage::addWikiText() method
Tidy will always be enabled with our future parsers. Hard-deprecate
this method which doesn't tidy the output.
Users of `OutputPage::addWikiText()` will be converted one-by-one to
`OutputPage::addWikiTextAsInterface()` so that any unexpected issues
(deliberately untidy wikitext added, which should be rare) can be
addressed.
Bug: T198214
Depends-On: I778ba9e6efed576605f492c9a073c7203b6c0477
Depends-On: I16529879a3b3aed960c5dc006e2af513d7e91fcd
Change-Id: If8353c37245d9d233d589f82c198668ccb3fce05
jenkins-bot [Wed, 24 Oct 2018 18:03:41 +0000 (18:03 +0000)]
Merge "RELEASE-NOTES-1.32: Add all new/changed libraries in composer.json"
jenkins-bot [Wed, 24 Oct 2018 17:45:34 +0000 (17:45 +0000)]
Merge "Remove deprecated "Parsoid v1 API" compatibility thunks"
jenkins-bot [Wed, 24 Oct 2018 17:14:34 +0000 (17:14 +0000)]
Merge "HTMLForm: Remove parameters 'notice', 'notice-messages', 'notice-message'"
C. Scott Ananian [Tue, 25 Sep 2018 19:44:33 +0000 (15:44 -0400)]
Remove deprecated "Parsoid v1 API" compatibility thunks
These have been deprecated since MW 1.26, and were hard deprecated
in MW 1.32.
Bug: T205029
Change-Id: I387794ecceec8aec1bd01923a71673aa2ddf4282
David Barratt [Tue, 26 Jun 2018 23:12:05 +0000 (19:12 -0400)]
List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo.
The ApiQueryBlocks and ApiQueryUserinfo endpoints will now return whether or not the block is
sitewide or partial. Partial block restrictions can be returned with ApiQueryBlocks.
Bug: T197141
Change-Id: I76eb4cac4dc989c621a00a39996faebd0eb9892c
David Barratt [Tue, 19 Jun 2018 19:57:34 +0000 (15:57 -0400)]
Update Special:BlockList to present Partial Block details from the database
The Special:BlockList page will be updated to show details from the Partial
Block within the "Block parameters" column. The format of the column will
change to make the details more readable.
Bug: T197143
Change-Id: Ibd79b049d93e427c2d541f8ef93005847482ef59
James D. Forrester [Wed, 24 Oct 2018 14:58:47 +0000 (07:58 -0700)]
Follow-up
cfa70ea6d0: Fix rebase artefact, also remove preference listing
Change-Id: Ia146f013beba2c82a8f76355b49a4192fbd0ed3b
Alangi Derick [Tue, 23 Oct 2018 13:38:42 +0000 (14:38 +0100)]
Minor cleanup of languages/ConverterRule.php
Remove extra space before comma and fix
minor issues with line comments.
Change-Id: I0306fe172eaa29ab504394f0a80b8652089a809c
Aaron Schulz [Wed, 24 Oct 2018 11:35:14 +0000 (04:35 -0700)]
rdbms: fix connection reuse logic in LoadBalancer for postgres
Change-Id: Ic4b7af156fbed54aae0a34a0bbba76490cd505e0
Aaron Schulz [Wed, 24 Oct 2018 09:48:14 +0000 (02:48 -0700)]
Silence transaction profiler master queries notices for rollback
Change-Id: I53f0149cbf69ee2e57fe556668dd6cbfadd79823
jenkins-bot [Wed, 24 Oct 2018 05:30:14 +0000 (05:30 +0000)]
Merge "Remove old "bulletin board style toolbar" from core"
jenkins-bot [Wed, 24 Oct 2018 03:15:39 +0000 (03:15 +0000)]
Merge "Enforce partial blocks"
jenkins-bot [Wed, 24 Oct 2018 01:45:25 +0000 (01:45 +0000)]
Merge "Add partial block details to block-log entries."
jenkins-bot [Wed, 24 Oct 2018 01:45:18 +0000 (01:45 +0000)]
Merge "Update Special:Block to set Partial Blocks"
jenkins-bot [Wed, 24 Oct 2018 01:35:54 +0000 (01:35 +0000)]
Merge "TitlesMultiselectWidget: Add a widget that allows selection of multiple titles"
jenkins-bot [Wed, 24 Oct 2018 01:28:36 +0000 (01:28 +0000)]
Merge "Add block restriction classes"
Dayllan Maza [Mon, 27 Aug 2018 01:45:18 +0000 (21:45 -0400)]
Enforce partial blocks
Enforce partial blocks and display a slightly different block
notice depending on if the block is sitewide or not
Bug: T197117
Depends-On: I675316dddf272fd0d6172ecad3882160752bf780
Change-Id: I8a3635a4a04a33912eb139b7b13c4bd874183d31
Tim Starling [Wed, 24 Oct 2018 00:21:28 +0000 (17:21 -0700)]
Fix slow query counting by unindexed field ar_page_id
Bug: T207530
Change-Id: I81a70ca03fd219d2e96b17714645d9cc4f99b3b9
Dayllan Maza [Wed, 19 Sep 2018 05:51:49 +0000 (01:51 -0400)]
Add partial block details to block-log entries.
Block information needs to be more detailed if a block is not
sitewide. With this change, page restrictions will be visible
as part of the block information in Special:Contributions,
Special:Block, and Special:Log and via API
Bug: T197108
Change-Id: I5d2ef606f709bdd60bf52e2a048890b0f6360fca
David Barratt [Mon, 27 Aug 2018 22:19:37 +0000 (18:19 -0400)]
Update Special:Block to set Partial Blocks
Make the necessary UI changes to Special:Block in order to set/update
partial blocks.
Bug: T197109
Change-Id: Ib3067824b5dcbdd893ab1f165d169a35d0716cb2
Moriel Schottlender [Thu, 30 Aug 2018 00:33:32 +0000 (17:33 -0700)]
TitlesMultiselectWidget: Add a widget that allows selection of multiple titles
Add the widget in both PHP and JS for OOUI, and into HTMLForm
definitions.
In JS, the widget uses the engine from mw.widgets.TitleWidget
with the async support from OO.ui.mixin.RequestManager.
The PHP version provides a textarea, like UsersMultiselectWidget.php
which is then infused if JS is available.
Also, add highlightSearchQuery option for TitleWidget to allow for
not highlighting the partial search query the user typed in, if the
UI requires it. This option (highlighting partial result) is already
optional in the TitleOptionWidget, so this config exposes that
optionality in the TitleWidget widget for its menu children.
Notes:
HTMLTitlesMultiselectField is a duplication of HTMLUsersMultiselectField
except for:
- The configuration variable changed to 'titles' (from 'users')
- OOUI modules were adjusted for the TitlesMultiselectWidget
- The PHP version instantiates a MediaWiki\Widget\TitlesMultiselectWidget
TitlesMultiselectWidget is a duplication of UsersMultiselectWidget
except for:
- $usersArray was renamed to $titlesArray
- getJavascriptClassName returns the correct js class for
mw.widgets.TitlesMultiselectWidget for infusion.
Bug: T197109
Depends-On: I675316dddf272fd0d6172ecad3882160752bf780
Change-Id: Ie96947a35f70b76731e16ae5b85de815dfa4a8ce
Dayllan Maza [Thu, 16 Aug 2018 04:55:55 +0000 (00:55 -0400)]
Add block restriction classes
Partial blocks logic will be used in multiple places. This
classes will group block restriction functionality to avoid
code duplication
Bug: T202036
Change-Id: I675316dddf272fd0d6172ecad3882160752bf780
Translation updater bot [Tue, 23 Oct 2018 19:53:55 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If085dbc6560e9580ac86ddb42a4f730d47f1e605
James D. Forrester [Tue, 23 Oct 2018 17:56:52 +0000 (10:56 -0700)]
RELEASE-NOTES-1.32: Add all new/changed libraries in composer.json
Change-Id: I50b47470b531b04642913b36dc7b4282476df6db
jenkins-bot [Tue, 23 Oct 2018 18:54:35 +0000 (18:54 +0000)]
Merge "Remove fixed phpcs:ignore"
Umherirrender [Tue, 23 Oct 2018 18:35:00 +0000 (20:35 +0200)]
Remove fixed phpcs:ignore
Follow-Up: I418345870e25fa37df0195ddc74193b54fe6d2a5
Change-Id: I0b3a546455c2f35d3aeadbdd31a07bdb1958a74c
James D. Forrester [Tue, 23 Oct 2018 17:52:51 +0000 (10:52 -0700)]
RELEASE-NOTES-1.32: Add all new/changed libraries in resources/lib
Change-Id: I1dffba3bb31850e1a2f1529c49329ba7c9c7d4a7
Ariel T. Glenn [Tue, 23 Oct 2018 15:18:47 +0000 (18:18 +0300)]
fix stubs dump query to use straight join
regression from a combination of
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/380669/
and
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/459885/
We have to do a straight join for all stubs, since they all
now order revisions by rev_id after deployment of the second
patchset above.
Bug: T207628
Change-Id: I4d2a311c14c66d4813eb9fc3c587fa3ddb958454