function wfRunHooks( $event, $args = array() ) {
return Hooks::run( $event, $args );
}
+
+/**
+ * Unserialize a string to a PHP value without throwing E_NOTICE. Simply a
+ * wrapper around unserialize()
+ *
+ * @param $data string The serialized string
+ * @return mixed
+ */
+function wfUnserialize( $data ) {
+ wfSuppressWarnings();
+ $result = unserialize( $data );
+ wfRestoreWarnings();
+ return $result;
+}
return false;
}
- $exif = unserialize( $metadata );
+ $exif = wfUnserialize( $metadata );
if ( !$exif ) {
return false;
}
// are less consistent.
);
}
+
+ public function testUnserialize() {
+ $this->assertEquals( '', wfUnserialize( 's:0:"";') );
+ $this->assertEquals( false, wfUnserialize( '0' ),
+ 'Invalid input to unserialize()' );
+ }
/* TODO: many more! */
}
<?php
class FormatMetadataTest extends MediaWikiTestCase {
public function testInvalidDate() {
+ global $wgShowEXIF;
+ if ( !$wgShowEXIF ) {
+ $this->markTestIncomplete( "This test needs the exif extension." );
+ }
+
$file = UnregisteredLocalFile::newFromPath( dirname( __FILE__ ) .
'/broken_exif_date.jpg', 'image/jpeg' );
// Throws an error if bug hit
$meta = $file->formatMetadata();
+ $this->assertNotEquals( false, $meta, 'Valid metadata extracted' );
// Find date exif entry
$this->assertArrayHasKey( 'visible', $meta );