Fixed $flags bit operation precedence fail in User::loadFromDatabase()
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 2 Jun 2015 18:38:43 +0000 (11:38 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 2 Jun 2015 18:39:37 +0000 (18:39 +0000)
* The bug made READ_LATEST also act as READ_LOCKING

Bug: T100577
Bug: T100869
Bug: T98706
Change-Id: I85092970c236fc4482371216b9f6592c49a27942

includes/User.php

index eb2a2dc..fc07b6d 100644 (file)
@@ -1229,7 +1229,7 @@ class User implements IDBAccessObject {
                        self::selectFields(),
                        array( 'user_id' => $this->mId ),
                        __METHOD__,
-                       ( $flags & self::READ_LOCKING == self::READ_LOCKING )
+                       ( ( $flags & self::READ_LOCKING ) == self::READ_LOCKING )
                                ? array( 'LOCK IN SHARE MODE' )
                                : array()
                );