From 49948457ecf96838473503049745548434a04262 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 22 Feb 2017 13:09:06 -0800 Subject: [PATCH] resourceloader: Optimize WikiModule preload for reqs without wiki modules Currently it was still going through fetchTitleInfo() with an empty array on the majority of requests without wiki modules, e.g. load.php?modules=jquery. Bug: T158813 Change-Id: Ie33a2b4da572bb30b2e7a69db07790724ec2f03f --- includes/resourceloader/ResourceLoaderWikiModule.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/includes/resourceloader/ResourceLoaderWikiModule.php b/includes/resourceloader/ResourceLoaderWikiModule.php index 14d6e056e0..e8574f4833 100644 --- a/includes/resourceloader/ResourceLoaderWikiModule.php +++ b/includes/resourceloader/ResourceLoaderWikiModule.php @@ -357,6 +357,11 @@ class ResourceLoaderWikiModule extends ResourceLoaderModule { } } + if ( !$wikiModules ) { + // Nothing to preload + return; + } + $pageNames = array_keys( $allPages ); sort( $pageNames ); $hash = sha1( implode( '|', $pageNames ) ); -- 2.20.1