UploadFromUrl: Display an error to the user on invalid wpUploadFileURL
authorRohan <rohan1395@yahoo.com>
Sun, 15 Jun 2014 17:47:49 +0000 (23:17 +0530)
committerBartosz Dziewoński <matma.rex@gmail.com>
Wed, 23 Sep 2015 15:09:47 +0000 (17:09 +0200)
Removes check for URL validity from UploadFromUrl::isValidRequest()
so that an error can be thrown later and displayed to the user.

Bug: T34361
Change-Id: Idf4cfcd6199ef6e875f760e46db98248ba53a327

includes/upload/UploadFromUrl.php

index f578745..f897a79 100644 (file)
@@ -175,7 +175,6 @@ class UploadFromUrl extends UploadBase {
                $url = $request->getVal( 'wpUploadFileURL' );
 
                return !empty( $url )
-                       && Http::isValidURI( $url )
                        && $wgUser->isAllowed( 'upload_by_url' );
        }