Follows-up I94c7ab656bd1a04. An initial pass of marking various
hooks as unabortable.
* BeforePageDisplay (T173411)
* OutputPageParserOutput
* AfterFinalPageOutput
* SkinTemplateNavigation (T107980)
* SkinTemplateNavigation::SpecialPage (T107980)
* SkinTemplateNavigation::Universal
* PersonalUrls
Bug: T173615
Change-Id: I0cb333dd5ff74f7dca725ff210200a0779a9a360
// Avoid PHP 7.1 warning of passing $this by reference
$outputPage = $this;
Hooks::run( 'LanguageLinks', [ $this->getTitle(), &$this->mLanguageLinks, &$linkFlags ] );
// Avoid PHP 7.1 warning of passing $this by reference
$outputPage = $this;
Hooks::run( 'LanguageLinks', [ $this->getTitle(), &$this->mLanguageLinks, &$linkFlags ] );
- Hooks::run( 'OutputPageParserOutput', [ &$outputPage, $parserOutput ] );
+ Hooks::runWithoutAbort( 'OutputPageParserOutput', [ &$outputPage, $parserOutput ] );
// This check must be after 'OutputPageParserOutput' runs in addParserOutputMetadata
// so that extensions may modify ParserOutput to toggle TOC.
// This check must be after 'OutputPageParserOutput' runs in addParserOutputMetadata
// so that extensions may modify ParserOutput to toggle TOC.
$text = $parserOutput->getText();
// Avoid PHP 7.1 warning of passing $this by reference
$outputPage = $this;
$text = $parserOutput->getText();
// Avoid PHP 7.1 warning of passing $this by reference
$outputPage = $this;
- Hooks::run( 'OutputPageBeforeHTML', [ &$outputPage, &$text ] );
+ Hooks::runWithoutAbort( 'OutputPageBeforeHTML', [ &$outputPage, &$text ] );
$this->addHTML( $text );
}
$this->addHTML( $text );
}
$outputPage = $this;
// Hook that allows last minute changes to the output page, e.g.
// adding of CSS or Javascript by extensions.
$outputPage = $this;
// Hook that allows last minute changes to the output page, e.g.
// adding of CSS or Javascript by extensions.
- Hooks::run( 'BeforePageDisplay', [ &$outputPage, &$sk ] );
+ Hooks::runWithoutAbort( 'BeforePageDisplay', [ &$outputPage, &$sk ] );
try {
// This hook allows last minute changes to final overall output by modifying output buffer
try {
// This hook allows last minute changes to final overall output by modifying output buffer
- Hooks::run( 'AfterFinalPageOutput', [ $this ] );
+ Hooks::runWithoutAbort( 'AfterFinalPageOutput', [ $this ] );
} catch ( Exception $e ) {
ob_end_clean(); // bug T129657
throw $e;
} catch ( Exception $e ) {
ob_end_clean(); // bug T129657
throw $e;
- Hooks::run( 'PersonalUrls', [ &$personal_urls, &$title, $this ] );
+ Hooks::runWithoutAbort( 'PersonalUrls', [ &$personal_urls, &$title, $this ] );
// Avoid PHP 7.1 warning of passing $this by reference
$skinTemplate = $this;
// Avoid PHP 7.1 warning of passing $this by reference
$skinTemplate = $this;
- Hooks::run( 'SkinTemplateNavigation', [ &$skinTemplate, &$content_navigation ] );
+ Hooks::runWithoutAbort(
+ 'SkinTemplateNavigation',
+ [ &$skinTemplate, &$content_navigation ]
+ );
if ( $userCanRead && !$wgDisableLangConversion ) {
$pageLang = $title->getPageLanguage();
if ( $userCanRead && !$wgDisableLangConversion ) {
$pageLang = $title->getPageLanguage();
// Avoid PHP 7.1 warning of passing $this by reference
$skinTemplate = $this;
// Avoid PHP 7.1 warning of passing $this by reference
$skinTemplate = $this;
- Hooks::run( 'SkinTemplateNavigation::SpecialPage',
+ Hooks::runWithoutAbort( 'SkinTemplateNavigation::SpecialPage',
[ &$skinTemplate, &$content_navigation ] );
}
// Avoid PHP 7.1 warning of passing $this by reference
$skinTemplate = $this;
// Equiv to SkinTemplateContentActions
[ &$skinTemplate, &$content_navigation ] );
}
// Avoid PHP 7.1 warning of passing $this by reference
$skinTemplate = $this;
// Equiv to SkinTemplateContentActions
- Hooks::run( 'SkinTemplateNavigation::Universal', [ &$skinTemplate, &$content_navigation ] );
+ Hooks::runWithoutAbort( 'SkinTemplateNavigation::Universal',
+ [ &$skinTemplate, &$content_navigation ] );
// Setup xml ids and tooltip info
foreach ( $content_navigation as $section => &$links ) {
// Setup xml ids and tooltip info
foreach ( $content_navigation as $section => &$links ) {