Database class parameter and documentation cleanups
authorAaron Schulz <aschulz@wikimedia.org>
Mon, 19 Sep 2016 23:34:32 +0000 (16:34 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 20 Sep 2016 06:23:30 +0000 (23:23 -0700)
commit8c261ee924ae27dcfca694f5e5233e81f12f5dc9
tree85af8123d9669ea2dbd977a8d5f8a1357116001c
parent6890f201e3847f16ca89e78c2af06625cd9b8444
Database class parameter and documentation cleanups

* Document various parameter arrays.
* Fix $user = false loophole in Database::__construct().
* Set the Postgres port *before* calling super, as it is
  needed by open().
* Remove 'chronProt' parameter as it is lazy-loaded.

Change-Id: Icc1037efa1eee7ae6fdd2919f60001e6e29ae55c
includes/libs/rdbms/database/Database.php
includes/libs/rdbms/database/DatabasePostgres.php
includes/libs/rdbms/database/DatabaseSqlite.php
includes/libs/rdbms/lbfactory/LBFactory.php
includes/libs/rdbms/lbfactory/LBFactoryMulti.php
includes/libs/rdbms/lbfactory/LBFactorySimple.php
includes/libs/rdbms/loadbalancer/ILoadBalancer.php