From fd1e608caee198956d2d4cbdf9cb96870973a776 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Mon, 16 Apr 2018 21:20:58 -0700 Subject: [PATCH] rdbms: remove "m" prefix from LoadBalancer comments Change-Id: Ie239157eb6ee8b7991c45ef5c5c06a1caaba52c9 --- includes/libs/rdbms/loadbalancer/LoadBalancer.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php index be7d0212e4..01589ae4c2 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php @@ -369,7 +369,7 @@ class LoadBalancer implements ILoadBalancer { // Scale the configured load ratios according to each server's load and state $this->getLoadMonitor()->scaleLoads( $loads, $domain ); - // Pick a server to use, accounting for weights, load, lag, and mWaitForPos + // Pick a server to use, accounting for weights, load, lag, and "waitForPos" list( $i, $laggedReplicaMode ) = $this->pickReaderIndex( $loads, $domain ); if ( $i === false ) { // Replica DB connection unsuccessful @@ -379,7 +379,7 @@ class LoadBalancer implements ILoadBalancer { if ( $this->waitForPos && $i != $this->getWriterIndex() ) { // Before any data queries are run, wait for the server to catch up to the // specified position. This is used to improve session consistency. Note that - // when LoadBalancer::waitFor() sets mWaitForPos, the waiting triggers here, + // when LoadBalancer::waitFor() sets "waitForPos", the waiting triggers here, // so update laggedReplicaMode as needed for consistency. if ( !$this->doWait( $i ) ) { $laggedReplicaMode = true; @@ -424,7 +424,7 @@ class LoadBalancer implements ILoadBalancer { } else { $i = false; if ( $this->waitForPos && $this->waitForPos->asOfTime() ) { - // ChronologyProtecter sets mWaitForPos for session consistency. + // ChronologyProtecter sets "waitForPos" for session consistency. // This triggers doWait() after connect, so it's especially good to // avoid lagged servers so as to avoid excessive delay in that method. $ago = microtime( true ) - $this->waitForPos->asOfTime(); @@ -1140,7 +1140,7 @@ class LoadBalancer implements ILoadBalancer { $context ); - // If all servers were busy, mLastError will contain something sensible + // If all servers were busy, "lastError" will contain something sensible throw new DBConnectionError( null, $this->lastError ); } } -- 2.20.1