From facddc488ae8714e1f41035599a8f54056d0ab2f Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Tue, 14 May 2019 12:28:35 +0100 Subject: [PATCH] SearchResult: MW version number should be a string in wfDeprecated call Seems this was a typo and I think 1.32 which is a double/float will be implicitly converted to true (bool) because it will resolve 1.32 to 1 as integer and then 1 which maps to true (bool). To avoid this, use '1.32' instead of the integer form of the version. Change-Id: I2420396e110284f582cd79820ffc6064e247b4b9 --- includes/search/SearchResult.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/search/SearchResult.php b/includes/search/SearchResult.php index bd19a84e32..f85c58fe2d 100644 --- a/includes/search/SearchResult.php +++ b/includes/search/SearchResult.php @@ -285,7 +285,7 @@ class SearchResult { if ( $extensionData instanceof Closure ) { $this->extensionData = $extensionData; } elseif ( is_array( $extensionData ) ) { - wfDeprecated( __METHOD__ . ' with array argument', 1.32 ); + wfDeprecated( __METHOD__ . ' with array argument', '1.32' ); $this->extensionData = function () use ( $extensionData ) { return $extensionData; }; -- 2.20.1