From fa261ed50f3a8c6e845754f4f75c7b03073bef0f Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Fri, 28 Jun 2019 21:58:29 +0100 Subject: [PATCH] Avoid :checkbox Sizzle selector Just use [type="checkbox"] for better performance. Change-Id: I41e57873c4598ff3af6e70f913297c6b2d368f69 --- resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js | 2 +- resources/src/mediawiki.special.mute.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js b/resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js index 7d69fb6be1..5d6eaef81d 100644 --- a/resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/FormWrapperWidget.js @@ -71,7 +71,7 @@ FormWrapperWidget.prototype.onFormSubmit = function ( e ) { $( e.target ).find( 'input:not([type="hidden"],[type="submit"]), select' ).each( function () { var value = ''; - if ( !$( this ).is( ':checkbox' ) || $( this ).is( ':checked' ) ) { + if ( !$( this ).is( '[type="checkbox"]' ) || $( this ).is( ':checked' ) ) { value = $( this ).val(); } diff --git a/resources/src/mediawiki.special.mute.js b/resources/src/mediawiki.special.mute.js index 3d494d02ea..b9dcc21ab5 100644 --- a/resources/src/mediawiki.special.mute.js +++ b/resources/src/mediawiki.special.mute.js @@ -2,7 +2,7 @@ 'use strict'; $( function () { - var $inputs = $( '#mw-specialmute-form input:checkbox' ), + var $inputs = $( '#mw-specialmute-form input[type="checkbox"]' ), saveButton, $saveButton = $( '#save' ); function isFormChanged() { -- 2.20.1