From f2a83fe4ac1c603b7f70d12566e5f8e9bcba1bcd Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Thu, 16 Nov 2017 17:14:29 +0100 Subject: [PATCH] HTMLRadioField: Do not automatically infuse our RadioSelectInputWidgets This is really a workaround for an issue in a completely different place: JS RadioSelectInputWidget internally uses `` rather than real radio buttons, which does not work correctly with the code in mediawiki.special.preferences.confirmClose.js. Ideally we would change RadioSelectInputWidget to not do such weird things. However, I think this is actually a good thing to do in general. From the user's perspective, PHP RadioSelectInputWidget and JS RadioSelectInputWidget look and behave the same, so there's no reason to infuse and rebuild them. This behavior was implemented in f50cee1375201a5d3fd76c0c262cfc7e66bd5d42 in which unfortunately I did not document the reason for it. For other fields it makes obvious sense (the JS widgets have improvements like autocompletion, or at least look "pretty"), but I have no idea why I did it for this one. Bug: T180643 Change-Id: I53e50f8cda39466b2396b374e642c154487888bb --- includes/htmlform/fields/HTMLRadioField.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/includes/htmlform/fields/HTMLRadioField.php b/includes/htmlform/fields/HTMLRadioField.php index 77ea7cd211..c98e1ec07b 100644 --- a/includes/htmlform/fields/HTMLRadioField.php +++ b/includes/htmlform/fields/HTMLRadioField.php @@ -72,10 +72,6 @@ class HTMLRadioField extends HTMLFormField { ) ); } - protected function shouldInfuseOOUI() { - return true; - } - public function formatOptions( $options, $value ) { global $wgUseMediaWikiUIEverywhere; -- 2.20.1