From e73b63dd3b977eb3a1606d88f374a47ac0ae102c Mon Sep 17 00:00:00 2001 From: Fomafix Date: Tue, 24 Oct 2017 11:23:46 +0200 Subject: [PATCH 1/1] api.js: Add an else to avoid unnecessary checks If the first if matches then the second if can never match. Change-Id: I96d59b57cac414c9ee7008e2f284a7a4e3348f3f --- resources/src/mediawiki/api.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/resources/src/mediawiki/api.js b/resources/src/mediawiki/api.js index f178698ce8..0e9c19b4db 100644 --- a/resources/src/mediawiki/api.js +++ b/resources/src/mediawiki/api.js @@ -168,9 +168,8 @@ } else { parameters[ key ] = '\x1f' + parameters[ key ].join( '\x1f' ); } - } - // Boolean values are only false when not given at all - if ( parameters[ key ] === false || parameters[ key ] === undefined ) { + } else if ( parameters[ key ] === false || parameters[ key ] === undefined ) { + // Boolean values are only false when not given at all delete parameters[ key ]; } } -- 2.20.1