From e4277f170be4cb8aee0fe407793db47a94ec24c2 Mon Sep 17 00:00:00 2001 From: Amir Sarabadani Date: Thu, 22 Mar 2018 13:57:28 +0100 Subject: [PATCH] Do not assume rc_patrolled is binary in ChangesListSpecialPage Bug: T184791 Change-Id: Idd9fc4b37da2d862f84d3aacd9966872958bc9eb --- includes/specialpage/ChangesListSpecialPage.php | 2 +- .../phpunit/includes/specialpage/ChangesListSpecialPageTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/specialpage/ChangesListSpecialPage.php b/includes/specialpage/ChangesListSpecialPage.php index b8d706333e..b9d20bea16 100644 --- a/includes/specialpage/ChangesListSpecialPage.php +++ b/includes/specialpage/ChangesListSpecialPage.php @@ -490,7 +490,7 @@ abstract class ChangesListSpecialPage extends SpecialPage { 'queryCallable' => function ( $specialClassName, $ctx, $dbr, &$tables, &$fields, &$conds, &$query_options, &$join_conds ) { - $conds[] = 'rc_patrolled = 1'; + $conds[] = 'rc_patrolled != 0'; }, 'cssClassSuffix' => 'unpatrolled', 'isRowApplicableCallable' => function ( $ctx, $rc ) { diff --git a/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php b/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php index aac25d8bbc..d612b538d0 100644 --- a/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php +++ b/tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php @@ -356,7 +356,7 @@ class ChangesListSpecialPageTest extends AbstractChangesListSpecialPageTestCase $user = $this->getTestSysop()->getUser(); $this->assertConditions( [ # expected - "rc_patrolled = 1", + "rc_patrolled != 0", ], [ 'hideunpatrolled' => 1, -- 2.20.1