From df103765acbcb7d62013dfafeb7233cd450b9bea Mon Sep 17 00:00:00 2001 From: daniel Date: Thu, 11 Jan 2018 13:56:17 +0100 Subject: [PATCH] Add test for newNullRevision with bad page ID Bug: T184687 Change-Id: I893d71999f034f84bf067dedacb821a74374ea7c --- tests/phpunit/includes/RevisionDbTestBase.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/phpunit/includes/RevisionDbTestBase.php b/tests/phpunit/includes/RevisionDbTestBase.php index 6139524533..427a95e656 100644 --- a/tests/phpunit/includes/RevisionDbTestBase.php +++ b/tests/phpunit/includes/RevisionDbTestBase.php @@ -619,6 +619,16 @@ abstract class RevisionDbTestBase extends MediaWikiTestCase { $this->assertEquals( __METHOD__, $rev->getContent()->getNativeData() ); } + /** + * @covers Revision::newNullRevision + */ + public function testNewNullRevision_badPage() { + $dbw = wfGetDB( DB_MASTER ); + $rev = Revision::newNullRevision( $dbw, -1, 'a null revision', false ); + + $this->assertNull( $rev ); + } + /** * @covers Revision::insertOn */ -- 2.20.1