From d9f0a5f685aaedd43fb1cbcabbf966828a1b41d6 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 7 Feb 2018 16:15:32 -0800 Subject: [PATCH] objectcache: remove unused constant and expand on a comment Change-Id: I3342497d657291d20325a3d87cc634f53d7776c4 --- includes/libs/objectcache/WANObjectCache.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/libs/objectcache/WANObjectCache.php b/includes/libs/objectcache/WANObjectCache.php index d9398196f5..eec766b9d7 100644 --- a/includes/libs/objectcache/WANObjectCache.php +++ b/includes/libs/objectcache/WANObjectCache.php @@ -134,8 +134,6 @@ class WANObjectCache implements IExpiringStore, LoggerAwareInterface { const LOCK_TTL = 10; /** Default remaining TTL at which to consider pre-emptive regeneration */ const LOW_TTL = 30; - /** Default time-since-expiry on a miss that makes a key "hot" */ - const LOCK_TSE = 1; /** Never consider performing "popularity" refreshes until a key reaches this age */ const AGE_NEW = 60; @@ -284,7 +282,8 @@ class WANObjectCache implements IExpiringStore, LoggerAwareInterface { * (e.g. the default REPEATABLE-READ in innoDB). Even for mutable data, that * isolation can largely be maintained by doing the following: * - a) Calling delete() on entity change *and* creation, before DB commit - * - b) Keeping transaction duration shorter than delete() hold-off TTL + * - b) Keeping transaction duration shorter than the delete() hold-off TTL + * - c) Disabling interim key caching via useInterimHoldOffCaching() before get() calls * * However, pre-snapshot values might still be seen if an update was made * in a remote datacenter but the purge from delete() didn't relay yet. -- 2.20.1