From d60e387b2b796999122fb45e9c19b4cfec8948bb Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Thu, 2 Nov 2017 16:48:45 -0700 Subject: [PATCH] RCFilters: Remove redundant replaceUpdatedUrl method The method should call updateURL anyways. If it's initializing, the comparison to the original URL will still be false and the system will apply replaceState on the URL. Change-Id: Ibfa104ed2aba94a5c17ed8ce3580a089d60e4d97 --- .../src/mediawiki.rcfilters/mw.rcfilters.Controller.js | 2 +- .../src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js index d1092a1ced..28b94e49a3 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js @@ -856,7 +856,7 @@ * without adding an history entry. */ mw.rcfilters.Controller.prototype.replaceUrl = function () { - this.uriProcessor.replaceUpdatedUri(); + this.uriProcessor.updateURL(); }; /** diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js index 0e20e3f08b..c25aa738ac 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js @@ -54,13 +54,6 @@ return Number( uriQuery.urlversion || 1 ); }; - /** - * Replace the current URI with an updated one from the model state - */ - mw.rcfilters.UriProcessor.prototype.replaceUpdatedUri = function () { - this.constructor.static.replaceState( this.getUpdatedUri() ); - }; - /** * Get an updated mw.Uri object based on the model state * -- 2.20.1