From b1436afb11f98a2d7e77bc53e789bb06c26e0c44 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Wed, 1 Mar 2017 17:43:42 +0000 Subject: [PATCH] stylelint: drop selector-pseudo-element-colon-notation exception and make pass Change-Id: Idfe36e3efb4a1c26ad677d3c9732ce66d39b9a60 --- .stylelintrc | 1 - .../src/mediawiki.ui/components/checkbox.less | 16 ++++++++-------- resources/src/mediawiki.ui/components/radio.less | 16 ++++++++-------- 3 files changed, 16 insertions(+), 17 deletions(-) diff --git a/.stylelintrc b/.stylelintrc index 08c49ca4d7..93f136b892 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -6,7 +6,6 @@ "no-descending-specificity": null, "selector-no-id": null, - "selector-pseudo-element-colon-notation": null, "value-keyword-case": null } diff --git a/resources/src/mediawiki.ui/components/checkbox.less b/resources/src/mediawiki.ui/components/checkbox.less index b72573da2e..2ca20a5b5e 100644 --- a/resources/src/mediawiki.ui/components/checkbox.less +++ b/resources/src/mediawiki.ui/components/checkbox.less @@ -68,7 +68,7 @@ } // the pseudo before element of the label after the checkbox now looks like a checkbox - & + label::before { + & + label:before { content: ''; background-color: #fff; .background-image-svg( 'images/checked.svg', 'images/checked.png' ); @@ -91,33 +91,33 @@ } // when the input is checked, style the label pseudo before element that followed as a checked checkbox - &:checked + label::before { + &:checked + label:before { .background-size( 100%, 100% ); } - &:active + label::before { + &:active + label:before { background-color: @colorGray13; border-color: @colorGray13; } - &:focus + label::before { + &:focus + label:before { border-width: 2px; } - &:focus:hover + label::before, - &:hover + label::before { + &:focus:hover + label:before, + &:hover + label:before { border-bottom-width: 3px; } // disabled checkboxes have a gray background - &:disabled + label::before { + &:disabled + label:before { cursor: default; background-color: @colorGray14; border-color: @colorGray14; } // disabled and checked checkboxes have a white circle - &:disabled:checked + label::before { + &:disabled:checked + label:before { .background-image-svg( 'images/checked_disabled.svg', 'images/checked_disabled.png' ); } } diff --git a/resources/src/mediawiki.ui/components/radio.less b/resources/src/mediawiki.ui/components/radio.less index 1b3a7a0aa6..7cb2849798 100644 --- a/resources/src/mediawiki.ui/components/radio.less +++ b/resources/src/mediawiki.ui/components/radio.less @@ -60,7 +60,7 @@ margin-right: 0.4em; // the pseudo before element of the label after the radio now looks like a radio - & + label::before { + & + label:before { content: ''; background-color: #fff; .background-image-svg( 'images/radio_checked.svg', 'images/radio_checked.png' ); @@ -79,33 +79,33 @@ } // when the input is checked, style the label pseudo before element that followed as a checked radio - &:checked + label::before { + &:checked + label:before { .background-size( 100%, 100% ); } - &:active + label::before { + &:active + label:before { background-color: @colorGray13; border-color: @colorGray13; } - &:focus + label::before { + &:focus + label:before { border-width: 2px; } - &:focus:hover + label::before, - &:hover + label::before { + &:focus:hover + label:before, + &:hover + label:before { border-bottom-width: 3px; } // disabled radios have a gray background - &:disabled + label::before { + &:disabled + label:before { background-color: @colorGray14; border-color: @colorGray14; cursor: default; } // disabled and checked radios have a white circle - &:disabled:checked + label::before { + &:disabled:checked + label:before { .background-image-svg( 'images/radio_disabled.svg', 'images/radio_disabled.png' ); } } -- 2.20.1