From a8875303f820de9c7eec32988a8eabf24e0417f0 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Mon, 26 Jun 2017 16:49:52 -0700 Subject: [PATCH] RCFilters: Always use the filled bookmark icon (unClip) Bug: T168828 Change-Id: I436f00bc87db143116125a185abd8000132df195 --- .../mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js index 3f920f0013..1a68b49f6f 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js @@ -24,7 +24,7 @@ // Parent mw.rcfilters.ui.SaveFiltersPopupButtonWidget.parent.call( this, $.extend( { framed: false, - icon: 'clip', + icon: 'unClip', $overlay: this.$overlay, title: mw.msg( 'rcfilters-savedqueries-add-new-title' ), popup: { @@ -36,7 +36,7 @@ } }, config ) ); // // HACK: Add an icon to the popup head label - this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon: 'clip' } ) ).$element ); + this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon: 'unClip' } ) ).$element ); this.input = new OO.ui.TextInputWidget( { validate: /\S/ @@ -109,15 +109,6 @@ } }; - /** - * Respond to popup toggle event - * - * @param {boolean} isVisible Popup is visible - */ - mw.rcfilters.ui.SaveFiltersPopupButtonWidget.prototype.onPopupToggle = function ( isVisible ) { - this.setIcon( isVisible ? 'unClip' : 'clip' ); - }; - /** * Respond to popup ready event */ -- 2.20.1