From a6bd784b9ba15d48dd83cd46fd91d49eda77f994 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Sun, 10 Mar 2019 19:12:48 +0100 Subject: [PATCH] ProtectionForm: Add type hint to ::showLogExtract() header https://codesearch.wmflabs.org/core/?q=showLogExtract%5C(&i=nope&files=&repos= according to codesearch shows that this method takes as first argument an output page object and also, objects are passed by reference by default so removed &. Change-Id: I167ae6300b37d4e9292bd8ad14351f1ca35184d2 --- includes/ProtectionForm.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php index 6ce7ef4757..0e18e46a3b 100644 --- a/includes/ProtectionForm.php +++ b/includes/ProtectionForm.php @@ -622,10 +622,10 @@ class ProtectionForm { /** * Show protection long extracts for this page * - * @param OutputPage &$out + * @param OutputPage $out * @private */ - function showLogExtract( &$out ) { + function showLogExtract( OutputPage $out ) { # Show relevant lines from the protection log: $protectLogPage = new LogPage( 'protect' ); $out->addHTML( Xml::element( 'h2', null, $protectLogPage->getName()->text() ) ); -- 2.20.1