From a4efd27998e0202eec82aea5e5fc70650fbdf514 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Mon, 22 Aug 2016 06:36:09 +0200 Subject: [PATCH] Directly use getSession for specialPreferencesSaveSuccess Change-Id: If9017f6c42f4c8f697504e3b92cee8bfb907b8e7 --- includes/Preferences.php | 2 +- includes/specials/SpecialPreferences.php | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/includes/Preferences.php b/includes/Preferences.php index 70addfcf90..5a9f0b055d 100644 --- a/includes/Preferences.php +++ b/includes/Preferences.php @@ -1494,7 +1494,7 @@ class Preferences { $context = $form->getContext(); // Set session data for the success message - $context->getRequest()->setSessionData( 'specialPreferencesSaveSuccess', 1 ); + $context->getRequest()->getSession()->set( 'specialPreferencesSaveSuccess', 1 ); $context->getOutput()->redirect( $url ); } diff --git a/includes/specials/SpecialPreferences.php b/includes/specials/SpecialPreferences.php index f00477f7f2..3697e5da6b 100644 --- a/includes/specials/SpecialPreferences.php +++ b/includes/specials/SpecialPreferences.php @@ -53,10 +53,10 @@ class SpecialPreferences extends SpecialPage { $out->addModules( 'mediawiki.special.preferences' ); $out->addModuleStyles( 'mediawiki.special.preferences.styles' ); - $request = $this->getRequest(); - if ( $request->getSessionData( 'specialPreferencesSaveSuccess' ) ) { + $session = $this->getRequest()->getSession(); + if ( $session->get( 'specialPreferencesSaveSuccess' ) ) { // Remove session data for the success message - $request->setSessionData( 'specialPreferencesSaveSuccess', null ); + $session->remove( 'specialPreferencesSaveSuccess' ); $out->addModuleStyles( 'mediawiki.notification.convertmessagebox.styles' ); $out->addHtml( @@ -146,7 +146,7 @@ class SpecialPreferences extends SpecialPage { $user->saveSettings(); // Set session data for the success message - $this->getRequest()->setSessionData( 'specialPreferencesSaveSuccess', 1 ); + $this->getRequest()->getSession()->set( 'specialPreferencesSaveSuccess', 1 ); $url = $this->getPageTitle()->getFullURL(); $this->getOutput()->redirect( $url ); -- 2.20.1