From 9c0b86c952754fd02c67ac398f02cef9d90b8e92 Mon Sep 17 00:00:00 2001 From: Stephane Bisson Date: Tue, 2 May 2017 16:09:27 -0400 Subject: [PATCH] RC Filters: watch filter highlight When checking if lines are 'watchednew' for highlight purposes, make sure 'rc_timestamp' and 'wl_notificationtimestamp' are truthy. Bug: T163964 Change-Id: I3cd6cc9835db01229b8d1cc6ccfc371a36709ef2 --- includes/specialpage/ChangesListSpecialPage.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/specialpage/ChangesListSpecialPage.php b/includes/specialpage/ChangesListSpecialPage.php index 9074d30145..93cc18fa42 100644 --- a/includes/specialpage/ChangesListSpecialPage.php +++ b/includes/specialpage/ChangesListSpecialPage.php @@ -415,7 +415,9 @@ abstract class ChangesListSpecialPage extends SpecialPage { 'cssClassSuffix' => 'watchednew', 'isRowApplicableCallable' => function ( $ctx, $rc ) { return $rc->getAttribute( 'wl_user' ) && - $rc->getAttribute( 'rc_timestamp' ) > $rc->getAttribute( 'wl_notificationtimestamp' ); + $rc->getAttribute( 'rc_timestamp' ) && + $rc->getAttribute( 'wl_notificationtimestamp' ) && + $rc->getAttribute( 'rc_timestamp' ) >= $rc->getAttribute( 'wl_notificationtimestamp' ); }, ], [ -- 2.20.1