From 99b764f336761baa1832d8aaa5cc45b9347390e7 Mon Sep 17 00:00:00 2001 From: Daimona Eaytoy Date: Sun, 19 May 2019 15:51:25 +0200 Subject: [PATCH] SpecialAllMessages: Specify filter messages so we always escape them As reported by phan-taint-check, HTMLForm options have to be escaped. Bug: T223821 Change-Id: I663911a2c3d8a5c60d407e84ec528f71af2eafe9 --- includes/specials/SpecialAllMessages.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/specials/SpecialAllMessages.php b/includes/specials/SpecialAllMessages.php index 511b2e83a7..f6b8b90522 100644 --- a/includes/specials/SpecialAllMessages.php +++ b/includes/specials/SpecialAllMessages.php @@ -77,10 +77,10 @@ class SpecialAllMessages extends SpecialPage { 'type' => 'radio', 'name' => 'filter', 'label-message' => 'allmessages-filter', - 'options' => [ - $this->msg( 'allmessages-filter-unmodified' )->text() => 'unmodified', - $this->msg( 'allmessages-filter-all' )->text() => 'all', - $this->msg( 'allmessages-filter-modified' )->text() => 'modified', + 'options-messages' => [ + 'allmessages-filter-unmodified' => 'unmodified', + 'allmessages-filter-all' => 'all', + 'allmessages-filter-modified' => 'modified', ], 'default' => 'all', 'flatlist' => true, -- 2.20.1