From 91a1a3ba2fd0c3166212c223f2ede5cdd31617b5 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Tue, 2 Jan 2018 00:19:21 -0800 Subject: [PATCH] HooksTest: Covers Hooks::callHook too Change-Id: Id2b97b031b2fcf82a6fba66dae353db1acf340c3 --- tests/phpunit/includes/HooksTest.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/phpunit/includes/HooksTest.php b/tests/phpunit/includes/HooksTest.php index 666051666b..efe92ec4e9 100644 --- a/tests/phpunit/includes/HooksTest.php +++ b/tests/phpunit/includes/HooksTest.php @@ -69,6 +69,7 @@ class HooksTest extends MediaWikiTestCase { * @dataProvider provideHooks * @covers Hooks::register * @covers Hooks::run + * @covers Hooks::callHook */ public function testNewStyleHooks( $msg, $hook, $expectedFoo, $expectedBar ) { $foo = $bar = 'original'; @@ -85,6 +86,7 @@ class HooksTest extends MediaWikiTestCase { * @covers Hooks::register * @covers Hooks::getHandlers * @covers Hooks::run + * @covers Hooks::callHook */ public function testNewStyleHookInteraction() { global $wgHooks; @@ -124,6 +126,7 @@ class HooksTest extends MediaWikiTestCase { /** * @expectedException MWException * @covers Hooks::run + * @covers Hooks::callHook */ public function testUncallableFunction() { Hooks::register( 'MediaWikiHooksTest001', 'ThisFunctionDoesntExist' ); @@ -132,6 +135,7 @@ class HooksTest extends MediaWikiTestCase { /** * @covers Hooks::run + * @covers Hooks::callHook */ public function testFalseReturn() { Hooks::register( 'MediaWikiHooksTest001', function ( &$foo ) { @@ -149,6 +153,7 @@ class HooksTest extends MediaWikiTestCase { /** * @covers Hooks::runWithoutAbort + * @covers Hooks::callHook */ public function testRunWithoutAbort() { $list = []; @@ -171,6 +176,7 @@ class HooksTest extends MediaWikiTestCase { /** * @covers Hooks::runWithoutAbort + * @covers Hooks::callHook */ public function testRunWithoutAbortWarning() { Hooks::register( 'MediaWikiHooksTest001', function ( &$foo ) { -- 2.20.1