From 85c5bac952733c7a800dbe4e534dcaf120bf9fe5 Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Wed, 11 Oct 2017 17:05:03 -0700 Subject: [PATCH] RCFilters: Don't reload when removing highlighted item Bug: T164131 Change-Id: I1f50276a60b8aae3034409664dd77f6ba1d5d87c --- .../mediawiki.rcfilters/mw.rcfilters.Controller.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js index 6da8119517..f74dc3bbe6 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js @@ -452,12 +452,20 @@ */ mw.rcfilters.Controller.prototype.clearFilter = function ( filterName ) { var filterItem = this.filtersModel.getItemByName( filterName ), - isHighlighted = filterItem.isHighlighted(); + isHighlighted = filterItem.isHighlighted(), + isSelected = filterItem.isSelected(); - if ( filterItem.isSelected() || isHighlighted ) { + if ( isSelected || isHighlighted ) { this.filtersModel.clearHighlightColor( filterName ); this.filtersModel.toggleFilterSelected( filterName, false ); - this.updateChangesList(); + + if ( isSelected ) { + // Only update the changes list if the filter changed + // its selection state. If it only changed its highlight + // then don't reload + this.updateChangesList(); + } + this.filtersModel.reassessFilterInteractions( filterItem ); // Log filter grouping -- 2.20.1