From 7f02e0afb94e63449c8164314ff9979671009584 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Mon, 18 Dec 2017 19:24:46 -0800 Subject: [PATCH] RevisionTest: Revision::constructFromRowArray is not a function I'm guessing that RevisionStore::newMutableRevisionFromArray() is what is supposed to be tested here, since Revision::__construct() calls that if it gets an array. Change-Id: Ia6c2e7eb667aa746a12ce74aad62e58d2468defd --- tests/phpunit/includes/RevisionTest.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/phpunit/includes/RevisionTest.php b/tests/phpunit/includes/RevisionTest.php index b7f1a47d91..f4ad98d216 100644 --- a/tests/phpunit/includes/RevisionTest.php +++ b/tests/phpunit/includes/RevisionTest.php @@ -57,7 +57,7 @@ class RevisionTest extends MediaWikiTestCase { /** * @dataProvider provideConstructFromArray * @covers Revision::__construct - * @covers Revision::constructFromRowArray + * @covers \MediaWiki\Storage\RevisionStore::newMutableRevisionFromArray */ public function testConstructFromArray( $rowArray ) { $rev = new Revision( $rowArray, 0, $this->getMockTitle() ); @@ -68,7 +68,7 @@ class RevisionTest extends MediaWikiTestCase { /** * @covers Revision::__construct - * @covers Revision::constructFromRowArray + * @covers \MediaWiki\Storage\RevisionStore::newMutableRevisionFromArray */ public function testConstructFromEmptyArray() { $rev = new Revision( [], 0, $this->getMockTitle() ); @@ -106,7 +106,7 @@ class RevisionTest extends MediaWikiTestCase { /** * @dataProvider provideConstructFromArray_userSetAsExpected * @covers Revision::__construct - * @covers Revision::constructFromRowArray + * @covers \MediaWiki\Storage\RevisionStore::newMutableRevisionFromArray * * @param array $rowArray * @param mixed $expectedUserId null to expect the current wgUser ID -- 2.20.1