From 77b34ccdba518c8efb019a78ff3fa79c1f0a2cde Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Sun, 10 Sep 2017 15:19:24 -0700 Subject: [PATCH] Linker: Accept LinkTarget objects in link() Even though this function is deprecated, it'll make the migration to TitleValue easier. Change-Id: Idb16dd2dd50a5273bff5e0537825dc5e91f00d86 --- includes/Linker.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/Linker.php b/includes/Linker.php index c6736f8dd4..8d2829fad8 100644 --- a/includes/Linker.php +++ b/includes/Linker.php @@ -76,7 +76,7 @@ class Linker { * @since 1.18 Method exists since 1.16 as non-static, made static in 1.18. * @deprecated since 1.28, use MediaWiki\Linker\LinkRenderer instead * - * @param Title $target Can currently only be a Title, but this may + * @param LinkTarget $target Can currently only be a LinkTarget, but this may * change to support Images, literal URLs, etc. * @param string $html The HTML contents of the element, i.e., * the link text. This is raw HTML and will not be escaped. If null, @@ -107,8 +107,8 @@ class Linker { public static function link( $target, $html = null, $customAttribs = [], $query = [], $options = [] ) { - if ( !$target instanceof Title ) { - wfWarn( __METHOD__ . ': Requires $target to be a Title object.', 2 ); + if ( !$target instanceof LinkTarget ) { + wfWarn( __METHOD__ . ': Requires $target to be a LinkTarget object.', 2 ); return "$html"; } -- 2.20.1