From 6da45bcaefda29dc942e0805ff17e2e552797c8e Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Tue, 3 Nov 2015 16:44:52 -0800 Subject: [PATCH] Add updateRevisionOn() sanity check for existing pages too Change-Id: I4f2fc07b0365183efb431a828d40c557b691b18c --- includes/page/WikiPage.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php index ba68e62185..2d5cb786d7 100644 --- a/includes/page/WikiPage.php +++ b/includes/page/WikiPage.php @@ -1832,7 +1832,10 @@ class WikiPage implements Page, IDBAccessObject { $revisionId = $revision->insertOn( $dbw ); // Update page_latest and friends to reflect the new revision - $this->updateRevisionOn( $dbw, $revision, null, $oldIsRedirect ); + if ( !$this->updateRevisionOn( $dbw, $revision, null, $oldIsRedirect ) ) { + $dbw->rollback( __METHOD__ ); + throw new MWException( "Failed to update page row to use new revision." ); + } Hooks::run( 'NewRevisionFromEditComplete', array( $this, $revision, $baseRevId, $user ) ); -- 2.20.1