From 63478e1415907178778697ab1e2321d0dd1a596f Mon Sep 17 00:00:00 2001 From: umherirrender Date: Wed, 14 Oct 2015 09:12:01 +0200 Subject: [PATCH] Move the "shit" out There is no need for such words Change-Id: I0294c0e2381b96fd4377d7edcdf4d7e7fc0d06d3 --- includes/Title.php | 6 ++---- includes/specials/SpecialUndelete.php | 2 +- maintenance/backupTextPass.inc | 1 - 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/includes/Title.php b/includes/Title.php index 8e5fae93b9..7fb2b063ae 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -1008,10 +1008,8 @@ class Title { */ public function getNsText() { if ( $this->isExternal() ) { - // This probably shouldn't even happen. ohh man, oh yuck. - // But for interwiki transclusion it sometimes does. - // Shit. Shit shit shit. - // + // This probably shouldn't even happen, + // but for interwiki transclusion it sometimes does. // Use the canonical namespaces if possible to try to // resolve a foreign namespace. if ( MWNamespace::exists( $this->mNamespace ) ) { diff --git a/includes/specials/SpecialUndelete.php b/includes/specials/SpecialUndelete.php index 00ee327d00..447c3ef1c6 100644 --- a/includes/specials/SpecialUndelete.php +++ b/includes/specials/SpecialUndelete.php @@ -587,7 +587,7 @@ class PageArchive { $restored = 0; foreach ( $result as $row ) { - // Check for key dupes due to shitty archive integrity. + // Check for key dupes due to needed archive integrity. if ( $row->ar_rev_id ) { $exists = $dbw->selectField( 'revision', '1', array( 'rev_id' => $row->ar_rev_id ), __METHOD__ ); diff --git a/maintenance/backupTextPass.inc b/maintenance/backupTextPass.inc index 11a05904de..0ed584c480 100644 --- a/maintenance/backupTextPass.inc +++ b/maintenance/backupTextPass.inc @@ -699,7 +699,6 @@ class TextPassDumper extends BackupDumper { $this->progress( "Spawning database subprocess: $cmd" ); $this->spawnProc = proc_open( $cmd, $spec, $pipes ); if ( !$this->spawnProc ) { - // shit $this->progress( "Subprocess spawn failed." ); return false; -- 2.20.1