From 62bf6cad3d05022a166b2ab4901b7c5ae0c218b4 Mon Sep 17 00:00:00 2001 From: Alangi Derick Date: Mon, 3 Dec 2018 13:38:03 +0100 Subject: [PATCH] logging: Correct $logId default value in LogPager.php $logId holds the log entry ID of some specific log and the datatype is an integer (int) which is correct but looking at the constructor, it does take a bool (false) which contradicts the docs above. So per @Thiemo's advice after review of prev PS, it would be better to replace false with 0 and leave the docs untouched. Change-Id: Ieceb79a6cbaa248e1b7a7d3c1d51eb26bb3a2d84 --- includes/logging/LogPager.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/logging/LogPager.php b/includes/logging/LogPager.php index b31f1657d4..32afa37301 100644 --- a/includes/logging/LogPager.php +++ b/includes/logging/LogPager.php @@ -70,7 +70,7 @@ class LogPager extends ReverseChronologicalPager { */ public function __construct( $list, $types = [], $performer = '', $title = '', $pattern = false, $conds = [], $year = false, $month = false, $day = false, - $tagFilter = '', $action = '', $logId = false + $tagFilter = '', $action = '', $logId = 0 ) { parent::__construct( $list->getContext() ); $this->mConds = $conds; -- 2.20.1