From 618fef63d2814ae84feee78eadd0fd80a6a8ae90 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 21 Feb 2018 23:42:52 -0800 Subject: [PATCH] rdbms: add type hint to reuseConnection() This avoids IDEA warnings. Change-Id: Ic772d47785319f111c267461e4e42e9183d2815b --- includes/libs/rdbms/loadbalancer/ILoadBalancer.php | 2 +- includes/libs/rdbms/loadbalancer/LoadBalancer.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php index 088c3f2c67..7bbb530730 100644 --- a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php @@ -199,7 +199,7 @@ interface ILoadBalancer { * @param IDatabase $conn * @throws InvalidArgumentException */ - public function reuseConnection( $conn ); + public function reuseConnection( IDatabase $conn ); /** * Get a database connection handle reference diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php index ccdb48e9af..c87a919602 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php @@ -736,7 +736,7 @@ class LoadBalancer implements ILoadBalancer { return $conn; } - public function reuseConnection( $conn ) { + public function reuseConnection( IDatabase $conn ) { $serverIndex = $conn->getLBInfo( 'serverIndex' ); $refCount = $conn->getLBInfo( 'foreignPoolRefCount' ); if ( $serverIndex === null || $refCount === null ) { -- 2.20.1