From 614dd71670d6d73e3c3aa953f6afadd5b9187936 Mon Sep 17 00:00:00 2001 From: Derk-Jan Hartman Date: Sun, 17 Jan 2016 12:24:28 -0500 Subject: [PATCH] Ignore name-less inputs on preference page confirmCloseWindow check Ignore any fields that will not be submitted when checking if the user has made changes to the Preferences form. Bug: T122702 Change-Id: I1cf27267e60f2077180b7bb6a3bc29fded4b67f6 --- .../src/mediawiki.special/mediawiki.special.preferences.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/resources/src/mediawiki.special/mediawiki.special.preferences.js b/resources/src/mediawiki.special/mediawiki.special.preferences.js index 29322f423e..a756f22d4d 100644 --- a/resources/src/mediawiki.special/mediawiki.special.preferences.js +++ b/resources/src/mediawiki.special/mediawiki.special.preferences.js @@ -266,7 +266,7 @@ // Check if all of the form values are unchanged function isPrefsChanged() { - var inputs = $( '#mw-prefs-form :input' ), + var inputs = $( '#mw-prefs-form :input[name]' ), input, $input, inputType, index, optIndex, opt; @@ -276,7 +276,8 @@ $input = $( input ); // Different types of inputs have different methods for accessing defaults - if ( $input.is( 'select' ) ) { // has the property defaultSelected for each option for ( optIndex = 0; optIndex < input.options.length; optIndex++ ) { opt = input.options[ optIndex ]; if ( opt.selected !== opt.defaultSelected ) { -- 2.20.1