From 5ff92cd11ebcc3418e689a0ea3f170d4f1f78dc3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?M=C3=A1t=C3=A9=20Szab=C3=B3?= Date: Sat, 5 Oct 2019 18:27:30 +0200 Subject: [PATCH] BaseTemplate: Use explicit varargs in method parameters With the removal of HHVM support, we can now use explicit varargs in function arguments. This patch updates the BaseTemplateclass to do so, and also removes PhanCommentParamWithoutRealParam check suppressions, which are now redundant. Bug: T231710 Change-Id: If78bd1556c862a472afe3646fd362b3c6baefbe0 --- includes/skins/BaseTemplate.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/includes/skins/BaseTemplate.php b/includes/skins/BaseTemplate.php index dedf83abc8..0e9bc57a07 100644 --- a/includes/skins/BaseTemplate.php +++ b/includes/skins/BaseTemplate.php @@ -32,12 +32,11 @@ abstract class BaseTemplate extends QuickTemplate { * Get a Message object with its context set * * @param string $name Message name - * @param mixed $params,... Message params - * @suppress PhanCommentParamWithoutRealParam HHVM bug T228695#5450847 + * @param mixed ...$params Message params * @return Message */ - public function getMsg( $name /* ... */ ) { - return $this->getSkin()->msg( ...func_get_args() ); + public function getMsg( $name, ...$params ) { + return $this->getSkin()->msg( $name, ...$params ); } function msg( $str ) { -- 2.20.1