From 5a53d94111f4461813971ac9c344a68a589befd9 Mon Sep 17 00:00:00 2001 From: Rohan Date: Tue, 10 Jun 2014 20:20:21 +0530 Subject: [PATCH] Fix for Bug 63980 - Comparison of limits in pingLimiter is incorrect Change-Id: Ie9da2c5af82d60e974bd258554b9438c1667630a --- includes/User.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/User.php b/includes/User.php index f2d3d9b18d..526653b95a 100644 --- a/includes/User.php +++ b/includes/User.php @@ -1719,7 +1719,9 @@ class User { // If more than one group applies, use the group with the highest limit foreach ( $this->getGroups() as $group ) { if ( isset( $limits[$group] ) ) { - if ( $userLimit === false || $limits[$group] > $userLimit ) { + if ( $userLimit === false + || $limits[$group][0] / $limits[$group][1] > $userLimit[0] / $userLimit[1] + ) { $userLimit = $limits[$group]; } } -- 2.20.1