From 52a3335087091554e34d6e1167fbb82f549a3262 Mon Sep 17 00:00:00 2001 From: Daimona Eaytoy Date: Wed, 11 Sep 2019 11:14:34 +0200 Subject: [PATCH] deleteLogFormatter: explicitly declare parsedParametersDeleteLog Instead of having a dynamic property checked via isset(). Change-Id: I64e3a3135b898b65e789aa8307ab9e3ffa0e9f4a --- includes/logging/DeleteLogFormatter.php | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/includes/logging/DeleteLogFormatter.php b/includes/logging/DeleteLogFormatter.php index 3bc19ffd37..e8c4393645 100644 --- a/includes/logging/DeleteLogFormatter.php +++ b/includes/logging/DeleteLogFormatter.php @@ -31,6 +31,12 @@ use MediaWiki\Storage\RevisionRecord; * @since 1.19 */ class DeleteLogFormatter extends LogFormatter { + /** @var array|null */ + private $parsedParametersDeleteLog; + + /** + * @inheritDoc + */ protected function getMessageKey() { $key = parent::getMessageKey(); if ( in_array( $this->entry->getSubtype(), [ 'event', 'revision' ] ) ) { @@ -50,8 +56,11 @@ class DeleteLogFormatter extends LogFormatter { return $key; } + /** + * @inheritDoc + */ protected function getMessageParameters() { - if ( isset( $this->parsedParametersDeleteLog ) ) { + if ( $this->parsedParametersDeleteLog !== null ) { return $this->parsedParametersDeleteLog; } -- 2.20.1