From 4e8eed74233db1db69f178fb0f4f1f8d6416bd52 Mon Sep 17 00:00:00 2001
From: Reedy <reedy@wikimedia.org>
Date: Fri, 21 Sep 2018 00:06:07 +0100
Subject: [PATCH] Collapse some unnecessary else conditions

Change-Id: I9fe505f2f4ed4d10e13813d9f05127fd6571c874
---
 includes/specialpage/SpecialPageFactory.php | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/includes/specialpage/SpecialPageFactory.php b/includes/specialpage/SpecialPageFactory.php
index c6ffbe4d70..b9c2204e1b 100644
--- a/includes/specialpage/SpecialPageFactory.php
+++ b/includes/specialpage/SpecialPageFactory.php
@@ -419,16 +419,14 @@ class SpecialPageFactory {
 
 			if ( $page instanceof SpecialPage ) {
 				return $page;
-			} else {
-				// It's not a classname, nor a callback, nor a legacy constructor array,
-				// nor a special page object. Give up.
-				wfLogWarning( "Cannot instantiate special page $realName: bad spec!" );
-				return null;
 			}
 
-		} else {
-			return null;
+			// It's not a classname, nor a callback, nor a legacy constructor array,
+			// nor a special page object. Give up.
+			wfLogWarning( "Cannot instantiate special page $realName: bad spec!" );
 		}
+
+		return null;
 	}
 
 	/**
@@ -565,9 +563,9 @@ class SpecialPageFactory {
 				$context->getOutput()->redirect( $url );
 
 				return $title;
-			} else {
-				$context->setTitle( $page->getPageTitle( $par ) );
 			}
+
+			$context->setTitle( $page->getPageTitle( $par ) );
 		} elseif ( !$page->isIncludable() ) {
 			return false;
 		}
@@ -714,8 +712,8 @@ class SpecialPageFactory {
 		list( $name, $subpage ) = $this->resolveAlias( $alias );
 		if ( $name != null ) {
 			return SpecialPage::getTitleFor( $name, $subpage );
-		} else {
-			return null;
 		}
+
+		return null;
 	}
 }
-- 
2.20.1