From 4c14f2f1002e9f33e10bc1ccd1656af41db9eb37 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Fri, 12 Apr 2019 20:32:53 -0700 Subject: [PATCH] Improve comments of outputVariesOnRevisionMetaData() Change-Id: Ie54e068515ac09af27fdc38eef7863c3a4d252f8 --- includes/Revision/RenderedRevision.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/includes/Revision/RenderedRevision.php b/includes/Revision/RenderedRevision.php index d3e5938c86..c4a00545c4 100644 --- a/includes/Revision/RenderedRevision.php +++ b/includes/Revision/RenderedRevision.php @@ -380,9 +380,9 @@ class RenderedRevision implements SlotRenderingProvider { $method = __METHOD__; if ( $out->getFlag( 'vary-revision' ) ) { - // XXX: Would be just keep the output if the speculative revision ID was correct, - // but that can go wrong for some edge cases, like {{PAGEID}} during page creation. - // For that specific case, it would perhaps nice to have a vary-page flag. + // If {{PAGEID}} resolved to 0 or {{REVISIONTIMESTAMP}} used the current + // timestamp rather than that of an actual revision, then those words need + // to resolve to the actual page ID or revision timestamp, respectively. $this->saveParseLogger->info( "$method: Prepared output has vary-revision...\n" ); -- 2.20.1