From 48db568102e33be97eb4381d561ea0b4a96de6ed Mon Sep 17 00:00:00 2001 From: Reedy Date: Sat, 2 Jan 2016 20:56:43 +0000 Subject: [PATCH] WikiPage::testPreSaveTransform() was removed Change-Id: Ibce32556b8213a36876dcb4c6f385afa6e6875aa --- RELEASE-NOTES-1.27 | 1 + includes/page/WikiPage.php | 26 -------------------- tests/phpunit/includes/page/WikiPageTest.php | 16 ------------ 3 files changed, 1 insertion(+), 42 deletions(-) diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27 index d811ca98ef..d4ece7bbce 100644 --- a/RELEASE-NOTES-1.27 +++ b/RELEASE-NOTES-1.27 @@ -203,6 +203,7 @@ changes to languages because of Phabricator reports. * User::getSkin() was removed (deprecated since 1.18). * OutputPage::includeJQuery() was removed (deprecated since 1.17). * WikiPage::updateRestrictions() was removed (deprecated since 1.19). +* WikiPage::testPreSaveTransform() was removed (deprecated since 1.19). == Compatibility == diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php index e67c535f1b..00ac127ea0 100644 --- a/includes/page/WikiPage.php +++ b/includes/page/WikiPage.php @@ -3559,32 +3559,6 @@ class WikiPage implements Page, IDBAccessObject { } } - /** - * This function is called right before saving the wikitext, - * so we can do things like signatures and links-in-context. - * - * @deprecated since 1.19; use Parser::preSaveTransform() instead - * @param string $text Article contents - * @param User $user User doing the edit - * @param ParserOptions $popts Parser options, default options for - * the user loaded if null given - * @return string Article contents with altered wikitext markup (signatures - * converted, {{subst:}}, templates, etc.) - */ - public function preSaveTransform( $text, User $user = null, ParserOptions $popts = null ) { - global $wgParser, $wgUser; - - wfDeprecated( __METHOD__, '1.19' ); - - $user = is_null( $user ) ? $wgUser : $user; - - if ( $popts === null ) { - $popts = ParserOptions::newFromUser( $user ); - } - - return $wgParser->preSaveTransform( $text, $this->mTitle, $user, $popts ); - } - /** * Returns a list of updates to be performed when this page is deleted. The * updates should remove any information about this page from secondary data diff --git a/tests/phpunit/includes/page/WikiPageTest.php b/tests/phpunit/includes/page/WikiPageTest.php index 0a46f8a18c..002e86f534 100644 --- a/tests/phpunit/includes/page/WikiPageTest.php +++ b/tests/phpunit/includes/page/WikiPageTest.php @@ -1261,22 +1261,6 @@ more stuff ); } - /** - * @dataProvider providePreSaveTransform - * @covers WikiPage::preSaveTransform - */ - public function testPreSaveTransform( $text, $expected ) { - $this->hideDeprecated( 'WikiPage::preSaveTransform' ); - $user = new User(); - $user->setName( "127.0.0.1" ); - - // NOTE: assume Help namespace to contain wikitext - $page = $this->newPage( "Help:WikiPageTest_testPreloadTransform" ); - $text = $page->preSaveTransform( $text, $user ); - - $this->assertEquals( $expected, $text ); - } - /** * @covers WikiPage::factory */ -- 2.20.1