From 366bf6686c29b999c33138369c9fc8591911f54e Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 11 Oct 2019 23:55:34 +0100 Subject: [PATCH] profiler: Deprecate ProfilerOutputDb and profileinfo.php Bug: T231366 Change-Id: I962a794c6806aa014af4b904e8b974fb0f4384b0 (cherry picked from commit 7b87584d87d69d1de2209b13c767a08475b47f6e) --- RELEASE-NOTES-1.34 | 2 ++ includes/profiler/output/ProfilerOutputDb.php | 2 ++ profileinfo.php | 1 + 3 files changed, 5 insertions(+) diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34 index fbc29d7710..ed2cf9c2e3 100644 --- a/RELEASE-NOTES-1.34 +++ b/RELEASE-NOTES-1.34 @@ -516,6 +516,8 @@ because of Phabricator reports. * The Profiler::setTemplated and Profiler::getTemplated methods have been deprecated. Use Profiler::setAllowOutput and Profiler::getAllowOutput instead. +* The ProfilerOutputDb class, 'profiling' table, and profileinfo.php entry + point had been deprecated (T231366). * The Preprocessor_DOM implementation has been deprecated. It will be removed in a future release. Use the Preprocessor_Hash implementation instead. diff --git a/includes/profiler/output/ProfilerOutputDb.php b/includes/profiler/output/ProfilerOutputDb.php index ea5f7ad14b..27bcaeeb89 100644 --- a/includes/profiler/output/ProfilerOutputDb.php +++ b/includes/profiler/output/ProfilerOutputDb.php @@ -28,6 +28,7 @@ use Wikimedia\Rdbms\DBError; * * @ingroup Profiler * @since 1.25 + * @deprecated since 1.34 No longer maintained (T231366) */ class ProfilerOutputDb extends ProfilerOutput { /** @var bool Whether to store host data with profiling calls */ @@ -35,6 +36,7 @@ class ProfilerOutputDb extends ProfilerOutput { public function __construct( Profiler $collector, array $params ) { parent::__construct( $collector, $params ); + wfDeprecated( __CLASS__, '1.34' ); // Initialize per-host profiling from config, back-compat if available if ( isset( $this->params['perHost'] ) ) { diff --git a/profileinfo.php b/profileinfo.php index 7b652b74d5..aed2447c23 100644 --- a/profileinfo.php +++ b/profileinfo.php @@ -178,6 +178,7 @@ if ( isset( $_REQUEST['expand'] ) ) { $expand[$f] = true; } } +wfDeprecated( 'profileinfo.php', '1.34' ); // phpcs:ignore Squiz.Classes.ValidClassName.NotCamelCaps class profile_point { -- 2.20.1