From 2ba91524d3d5a6d162c040e043d920f85e238137 Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Tue, 2 Jan 2018 10:29:03 -0800 Subject: [PATCH] RCFilters: Correct looking for items in namespace group To look for the namespace items, we either search for things in the 'namesapces' view (plural) or the 'namespace' group (singular) so the code had a typo. This is a recurring typo, but overall, it makes more sense to look for items in the **group** of namespaces rather than in the namespace view, conceptually. Bug: T183910 Change-Id: Ic67a6f1afd3e95fe776fbc5c33ecb7af737055b4 --- .../mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js index bbc1d7e629..c9f59248d4 100644 --- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js +++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js @@ -911,7 +911,7 @@ mw.rcfilters.dm.FiltersViewModel.prototype.areNamespacesEffectivelyInverted = function () { return this.getInvertModel().isSelected() && this.getSelectedItems().some( function ( itemModel ) { - return itemModel.getGroupModel().getView() === 'namespace'; + return itemModel.getGroupModel().getName() === 'namespace'; } ); }; -- 2.20.1