From 213acd8202e01a2bbc60e73826746c373f64cdba Mon Sep 17 00:00:00 2001 From: addshore Date: Thu, 16 Mar 2017 10:18:59 +0000 Subject: [PATCH] Deprecate WikiRevision::$importer This was introduced in 9b3128eb2b654761f21fd4ca1d5a1a4b796dc912 but was not used there. It also currently looks unused, even when grepping for possible magic usages of 'importer' and "importer". We could go ahead and just remove this now, as anything that wants to set the $importer when the property is removed would still succeed. But lets adhere to the deprecation policy here. Change-Id: I5ac16dd87a95be6a3cdd4b16988d37d1d6104749 --- RELEASE-NOTES-1.29 | 1 + includes/import/WikiRevision.php | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29 index e2f74daa8e..04f5578808 100644 --- a/RELEASE-NOTES-1.29 +++ b/RELEASE-NOTES-1.29 @@ -265,6 +265,7 @@ changes to languages because of Phabricator reports. * Removed 'jquery.arrowSteps' module. (deprecated since 1.28) * The 'jquery.autoEllipsis' ResourceLoader module is now deprecated. * WikiRevision::$fileIsTemp was deprecated. +* WikiRevision::$importer was deprecated. == Compatibility == diff --git a/includes/import/WikiRevision.php b/includes/import/WikiRevision.php index 1f577b6cfa..4b76394205 100644 --- a/includes/import/WikiRevision.php +++ b/includes/import/WikiRevision.php @@ -31,7 +31,12 @@ * @ingroup SpecialPage */ class WikiRevision { - /** @todo Unused? */ + + /** + * @since 1.17 + * @deprecated in 1.29. Unused. + * @note Introduced in 9b3128eb2b654761f21fd4ca1d5a1a4b796dc912, unused there, unused now. + */ public $importer = null; /** @var Title */ -- 2.20.1