From 1a5b26f0b6049ed495b092100360be1267327e15 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Tue, 13 Nov 2018 17:28:48 -0800 Subject: [PATCH] Changelist "tags" item is wrapped in brackets via CSS In our quest to separate content from presentation, the parentheticals are moved into CSS. These support translation via the lessMessages ResourceLoader property. There is obviously a risk with this change of double brackets appearing. We might want to consider a new message to avoid this (at the cost of some translations being outdated). However, I believe it's better to have the double paranthetical wrap then to have English strings show up in the wrong places. We can update other translations if necessary. Bug: T205581 Change-Id: I9c3fb069fc93800f39a922feab56489f1614785c --- languages/i18n/en.json | 2 +- languages/i18n/qqq.json | 2 +- resources/src/mediawiki.special.changeslist.less | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/languages/i18n/en.json b/languages/i18n/en.json index 4acf6eb390..7e22fc151a 100644 --- a/languages/i18n/en.json +++ b/languages/i18n/en.json @@ -3951,7 +3951,7 @@ "tags-summary": "", "tag-filter": "[[Special:Tags|Tag]] filter:", "tag-filter-submit": "Filter", - "tag-list-wrapper": "([[Special:Tags|{{PLURAL:$1|Tag|Tags}}]]: $2)", + "tag-list-wrapper": "[[Special:Tags|{{PLURAL:$1|Tag|Tags}}]]: $2", "tag-mw-contentmodelchange": "content model change", "tag-mw-contentmodelchange-description": "Edits that [https://www.mediawiki.org/wiki/Special:MyLanguage/Help:ChangeContentModel change the content model] of a page", "tag-mw-new-redirect": "New redirect", diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json index ee53214662..ba2b6c2c34 100644 --- a/languages/i18n/qqq.json +++ b/languages/i18n/qqq.json @@ -4154,7 +4154,7 @@ "tags-summary": "{{doc-specialpagesummary|tags}}", "tag-filter": "Caption of a filter shown on lists of changes (e.g. [[Special:Log]], [[Special:Contributions]], [[Special:Newpages]], [[Special:Recentchanges]], [[Special:Recentchangeslinked]], page histories)", "tag-filter-submit": "Caption of the submit button displayed next to the tag filter on lists of changes (e.g. [[Special:Log]], [[Special:Contributions]], [[Special:Newpages]], [[Special:Recentchanges]], [[Special:Recentchangeslinked]], page histories)\n\n{{Identical|Filter}}", - "tag-list-wrapper": "Wrapper for the list of tags shown on recent changes, watchlists, history pages and diffs.\n\nParameters:\n* $1 - number of distinct tags for given edit\n* $2 - comma-separated list of tags for given edit", + "tag-list-wrapper": "Wrapper for the list of tags shown on recent changes, watchlists, history pages and diffs. The message will be wrapped in {{msg-mw|parentheses-start}} and {{msg-mw|parentheses-end}} if set. \n\nParameters:\n* $1 - number of distinct tags for given edit\n* $2 - comma-separated list of tags for given edit", "tag-mw-contentmodelchange": "Change tag for edits that change the content model of a page", "tag-mw-contentmodelchange-description": "Description for \"content model change\" change tag", "tag-mw-new-redirect": "Change tag for edits that make the page a redirect (either redirect creation or editing an existing page)", diff --git a/resources/src/mediawiki.special.changeslist.less b/resources/src/mediawiki.special.changeslist.less index 015c187b02..e2ee9a549c 100644 --- a/resources/src/mediawiki.special.changeslist.less +++ b/resources/src/mediawiki.special.changeslist.less @@ -69,6 +69,7 @@ .mw-changeslist-links, .mw-diff-bytes, +.mw-tag-markers, .mw-uctop { &:before { content: '@{msg-parentheses-start}'; -- 2.20.1