From 14fc5db36d0c15a6a62d24ee68c3b1ff31061a82 Mon Sep 17 00:00:00 2001 From: "James D. Forrester" Date: Fri, 7 Jul 2017 16:01:17 -0700 Subject: [PATCH] SpecialRecentchanges: Globals for config are bad, m'kay Change-Id: I9ca7aead42ffee1e891525fc80f3438157f4fb2f --- includes/specials/SpecialRecentchanges.php | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index bec87c592a..05bcc4de6b 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -138,10 +138,6 @@ class SpecialRecentChanges extends ChangesListSpecialPage { * @param string $subpage */ public function execute( $subpage ) { - global $wgStructuredChangeFiltersEnableSaving, - $wgStructuredChangeFiltersEnableExperimentalViews, - $wgStructuredChangeFiltersEnableLiveUpdate; - // Backwards-compatibility: redirect to new feed URLs $feedFormat = $this->getRequest()->getVal( 'feed' ); if ( !$this->including() && $feedFormat ) { @@ -184,15 +180,15 @@ class SpecialRecentChanges extends ChangesListSpecialPage { $out->addJsConfigVars( 'wgStructuredChangeFilters', $jsData['groups'] ); $out->addJsConfigVars( 'wgStructuredChangeFiltersEnableSaving', - $wgStructuredChangeFiltersEnableSaving + $this->getConfig()->get( 'StructuredChangeFiltersEnableSaving' ) ); $out->addJsConfigVars( 'wgStructuredChangeFiltersEnableExperimentalViews', - $wgStructuredChangeFiltersEnableExperimentalViews + $this->getConfig()->get( 'StructuredChangeFiltersEnableExperimentalViews' ) ); $out->addJsConfigVars( 'wgStructuredChangeFiltersEnableLiveUpdate', - $wgStructuredChangeFiltersEnableLiveUpdate + $this->getConfig()->get( 'StructuredChangeFiltersEnableLiveUpdate' ) ); $out->addJsConfigVars( 'wgRCFiltersChangeTags', -- 2.20.1