From 0bf48b72331598fa464886f2bc9ca8259c610175 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Fri, 23 Feb 2018 16:25:01 -0800 Subject: [PATCH] Remove redundant item loading code in User::createNew These lines were removed in 27c61fb1 but left in when I rebased 61b0c193 due to the conflict. The load() call handles all these fields, so there is no need to set mName and the load state flag. Change-Id: Id751241abf8d5592309744e96493122c6bc65f2b --- includes/user/User.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/includes/user/User.php b/includes/user/User.php index b5106ed631..babb571c94 100644 --- a/includes/user/User.php +++ b/includes/user/User.php @@ -4361,8 +4361,6 @@ class User implements IDBAccessObject, UserIdentity { $newUser = self::newFromId( $dbw->insertId() ); // Load the user from master to avoid replica lag $newUser->load( self::READ_LATEST ); - $newUser->mName = $fields['user_name']; - $newUser->setItemLoaded( 'name' ); $newUser->updateActorId( $dbw ); } else { $newUser = null; -- 2.20.1